Skip to content

Fix blank page issue #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
splitbrain wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix blank page issue #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
591d7d2
Consume the pending page break at the table of contents
splitbrain Aug 7, 2026
cd61956
Add a test for the page layout of an export
splitbrain Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
442 changes: 442 additions & 0 deletions _test/PageLayoutTest.php
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions _test/pages/one.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
====== Page One ======

The first exported page. [[http://dw2pdf.test/one|marker]]
3 changes: 3 additions & 0 deletions _test/pages/two.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
====== Page Two ======

The second exported page. [[http://dw2pdf.test/two|marker]]
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_bare/README.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Template fixture providing neither cover page, back page, header nor footer.
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_bare_back/back.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<div class="back">Back page <a href="http://dw2pdf.test/back">marker</a></div>
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_bare_cover/cover.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<div class="cover">Cover page <a href="http://dw2pdf.test/cover">marker</a></div>
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_bare_coverback/back.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<div class="back">Back page <a href="http://dw2pdf.test/back">marker</a></div>
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_bare_coverback/cover.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<div class="cover">Cover page <a href="http://dw2pdf.test/cover">marker</a></div>
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_first/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
any @ID@
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_first/footer_first.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
first @ID@
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_first/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
any @ID@
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_first/header_first.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
first @ID@
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_first_coverback/back.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<div class="back">Back page <a href="http://dw2pdf.test/back">marker</a></div>
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_first_coverback/cover.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<div class="cover">Cover page <a href="http://dw2pdf.test/cover">marker</a></div>
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_first_coverback/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
any @ID@
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_first_coverback/footer_first.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
first @ID@
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_first_coverback/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
any @ID@
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_first_coverback/header_first.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
first @ID@
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_oddeven/footer_even.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
even @ID@
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_oddeven/footer_odd.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
odd @ID@
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_oddeven/header_even.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
even @ID@
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_oddeven/header_odd.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
odd @ID@
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_oddeven_coverback/back.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<div class="back">Back page <a href="http://dw2pdf.test/back">marker</a></div>
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_oddeven_coverback/cover.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<div class="cover">Cover page <a href="http://dw2pdf.test/cover">marker</a></div>
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_oddeven_coverback/footer_even.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
even @ID@
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_oddeven_coverback/footer_odd.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
odd @ID@
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_oddeven_coverback/header_even.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
even @ID@
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_oddeven_coverback/header_odd.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
odd @ID@
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_plain/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
any @ID@
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_plain/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
any @ID@
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_plain_coverback/back.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<div class="back">Back page <a href="http://dw2pdf.test/back">marker</a></div>
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_plain_coverback/cover.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<div class="cover">Cover page <a href="http://dw2pdf.test/cover">marker</a></div>
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_plain_coverback/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
any @ID@
1 change: 1 addition & 0 deletions _test/tpl/dw2pdftest_plain_coverback/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
any @ID@
3 changes: 3 additions & 0 deletions src/Writer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,9 @@ public function toc(string $header): void
'pagenumstyle' => '1'
]);

// <tocpagebreak> starts a new page by itself, so consume any pending break instead of
// emitting a second one - that would leave a blank page between the ToC and the first page.
$this->breakBeforeNext = false;
$this->write('<tocpagebreak>', HTMLParserMode::HTML_BODY, false, false);
}

Expand Down