Skip to content

Rename extracted version to SPIN_DEP_VERSION #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fibonacci1729 merged 1 commit into from
Aug 26, 2026
Merged

Rename extracted version to SPIN_DEP_VERSION #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/release-trigger.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,12 +170,13 @@ jobs:
SPIN_TAG=$(grep -m1 'spin-app.*tag' Cargo.toml | sed -n 's/.*tag = "\([^"]*\)".*/\1/p') || true
SPIN_REV=$(grep -m1 'spin-app.*rev' Cargo.toml | sed -n 's/.*rev = "\([^"]*\)".*/\1/p') || true

# Not SPIN_VERSION: the Spin setup action already exports that as the CLI version.
if [ -n "$SPIN_TAG" ]; then
echo "SPIN_VERSION=$SPIN_TAG" >> "$GITHUB_ENV"
echo "SPIN_DEP_VERSION=$SPIN_TAG" >> "$GITHUB_ENV"
elif [ -n "$SPIN_REV" ]; then
echo "SPIN_VERSION=$SPIN_REV" >> "$GITHUB_ENV"
echo "SPIN_DEP_VERSION=$SPIN_REV" >> "$GITHUB_ENV"
else
echo "SPIN_VERSION=unknown" >> "$GITHUB_ENV"
echo "SPIN_DEP_VERSION=unknown" >> "$GITHUB_ENV"
fi

- name: create GitHub release
Expand All @@ -184,7 +185,7 @@ jobs:
run: |
gh release create ${{ env.RELEASE_TAG }} crates/${{ inputs.crate }}/artifacts/*/*.tar.gz \
--title ${{ env.RELEASE_TAG }} \
--notes "Based off Spin ${{ env.SPIN_VERSION }} dependencies" \
--notes "Based off Spin ${{ env.SPIN_DEP_VERSION }} dependencies" \
${{ env.PRERELEASE }}

# Canary builds: upload the un-shaed merged manifest produced above.
Expand Down
Loading