Skip to content

Output: marks on a command's output, held to its golden - #119

Merged
aledbf merged 2 commits into
mainfrom
infra-output-marks
Nov 19, 2026
Merged

aledbf merged 2 commits into
mainfrom
infra-output-marks

Conversation

@aledbf

@aledbf aledbf commented Nov 19, 2026

Copy link
Copy Markdown
Member

<Output> can now point at what matters in a golden without editing it: mark="…", ins="…" and del="…" are text of the output, passed to Starlight's <Code> as Expressive Code text markers.

  • Text, not line numbers: a line number keeps pointing after the golden moves, at whatever line is there now.
  • checkOutputMarks in tools/refgen fails on a marker the golden no longer has (Expressive Code marks nothing and says nothing then). It runs with and without spin, since it reads the copies in src/data/output. Tested in outputs_test.go.
  • The Markdown twin stays the plain block (src/lib/pages.ts drops the attributes).
  • use/agents: the diff's JSON marks the three kinds - added (ins), modified (mark), removed (del). It is the only <Output> today.
  • README: a paragraph on what a command prints and its marks.

go tool task check passes.

🤖 Generated with Claude Code

aledbf and others added 2 commits November 19, 2026 14:52
… on one it lost

Expressive Code marks nothing and says nothing when a marker's text is not
there, so a golden that changed would take the mark away unseen.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@aledbf
aledbf merged commit 47c9a6e into main Nov 19, 2026
2 checks passed
@aledbf
aledbf deleted the infra-output-marks branch November 19, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant