Repository navigation
connect: a first connection waits for the passkey that adds this computer's key, and says so - #41
Merged
Merged
Conversation
…that adds its key, and says so
spin code now adds the key this computer connects with when the person's account does not list
it - a first connection, VS Code's before anyone ran spin here - opening the page where their
passkey confirms it, and writes a {"confirming_key": {...}} line while it waits. The extension
moves code's deadline past that wait and shows it in the progress of opening and connecting,
where a refused key used to be an error.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A first connection from a computer - VS Code's, before anyone ran spin there - was refused for a key on nobody's account, and the way out was an error, a dialog and a terminal.
With spin-stack/spin#1253,
spin codeadds the key itself: it opens the page where the person's passkey confirms it, and writes a{"confirming_key": {...}}line while it waits. This extension:isCodeConfirmingKey), movescode's deadline past spin's ten-minute wait for the passkey, and leaves it out of the answer;The sign-in already runs
spin login, which with spin#1253 offers the key with the login, so most people confirm it there, once.Needs a spin release carrying spin#1253; with an older CLI the line never comes and nothing changes.
🤖 Generated with Claude Code