Skip to content

connect: a first connection waits for the passkey that adds this computer's key, and says so - #41

Merged
aledbf merged 1 commit into
mainfrom
key-confirm
Nov 16, 2026
Merged

aledbf merged 1 commit into
mainfrom
key-confirm

Conversation

@aledbf

@aledbf aledbf commented Nov 16, 2026

Copy link
Copy Markdown
Member

A first connection from a computer - VS Code's, before anyone ran spin there - was refused for a key on nobody's account, and the way out was an error, a dialog and a terminal.

With spin-stack/spin#1253, spin code adds the key itself: it opens the page where the person's passkey confirms it, and writes a {"confirming_key": {...}} line while it waits. This extension:

  • reads that line (isCodeConfirmingKey), moves code's deadline past spin's ten-minute wait for the passkey, and leaves it out of the answer;
  • says it in the progress of opening and of connecting: Confirm with your passkey, in the browser page spin opened, that connects to your workspaces.

The sign-in already runs spin login, which with spin#1253 offers the key with the login, so most people confirm it there, once.

Needs a spin release carrying spin#1253; with an older CLI the line never comes and nothing changes.

🤖 Generated with Claude Code

…that adds its key, and says so

spin code now adds the key this computer connects with when the person's account does not list
it - a first connection, VS Code's before anyone ran spin here - opening the page where their
passkey confirms it, and writes a {"confirming_key": {...}} line while it waits. The extension
moves code's deadline past that wait and shows it in the progress of opening and connecting,
where a refused key used to be an error.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@aledbf
aledbf merged commit 3e40693 into main Nov 16, 2026
3 checks passed
@aledbf
aledbf deleted the key-confirm branch November 16, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant