Repository navigation
license: ship the bundle's third-party notices in the VSIX - #40
Merged
Merged
Conversation
esbuild writes dist/THIRD_PARTY_NOTICES from its metafile: the license text of every npm package whose code reached dist/extension.js, as their terms demand of a copy. Today the bundle takes none, so the file says so; a package that starts reaching the bundle is named without anyone remembering to, and one with no license file fails the build. LICENSE's appendix names the copyright holder as the spin-stack Authors, the same line every spin-stack repository carries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
esbuild.mjswritesdist/THIRD_PARTY_NOTICESfrom esbuild's metafile: the license text of every npm package whose code reacheddist/extension.js. The bundle takes none today (onlynode:built-ins andvscode, which is external), so the file says so. A package with no license file fails the build..vscodeignorepacks the file into every VSIX:extension/dist/THIRD_PARTY_NOTICES, byte-identical across twotask packageruns.LICENSE: the appendix copyright line becomes "The spin-stack Authors".Not covered here: the spin CLI that
package:allputs atbin/<target>/spinis spin's binary, so its Go dependencies' notices come from spin's release. Once spin ships them, they belong next to the binary inbin/<target>/.Checked:
task lint typecheck test,go test ./...,unzip -l spinbox.vsix.🤖 Generated with Claude Code