Skip to content

license: ship the bundle's third-party notices in the VSIX - #40

Merged
aledbf merged 1 commit into
mainfrom
licenses-notices
Nov 16, 2026
Merged

aledbf merged 1 commit into
mainfrom
licenses-notices

Conversation

@aledbf

@aledbf aledbf commented Nov 16, 2026

Copy link
Copy Markdown
Member
  • esbuild.mjs writes dist/THIRD_PARTY_NOTICES from esbuild's metafile: the license text of every npm package whose code reached dist/extension.js. The bundle takes none today (only node: built-ins and vscode, which is external), so the file says so. A package with no license file fails the build.
  • .vscodeignore packs the file into every VSIX: extension/dist/THIRD_PARTY_NOTICES, byte-identical across two task package runs.
  • LICENSE: the appendix copyright line becomes "The spin-stack Authors".

Not covered here: the spin CLI that package:all puts at bin/<target>/spin is spin's binary, so its Go dependencies' notices come from spin's release. Once spin ships them, they belong next to the binary in bin/<target>/.

Checked: task lint typecheck test, go test ./..., unzip -l spinbox.vsix.

🤖 Generated with Claude Code

esbuild writes dist/THIRD_PARTY_NOTICES from its metafile: the license
text of every npm package whose code reached dist/extension.js, as their
terms demand of a copy. Today the bundle takes none, so the file says so;
a package that starts reaching the bundle is named without anyone
remembering to, and one with no license file fails the build.

LICENSE's appendix names the copyright holder as the spin-stack Authors,
the same line every spin-stack repository carries.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@aledbf
aledbf merged commit 863c563 into main Nov 16, 2026
3 checks passed
@aledbf
aledbf deleted the licenses-notices branch November 16, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant