Repository navigation
test: Remote-SSH in a real VS Code against a spin e2e stack - #31
Merged
Merged
Conversation
task test:remote-ssh installs the packaged VSIX and Microsoft's Remote-SSH
from the Marketplace into VS Code stable and opens vscode-remote://
ssh-remote+spin.<ws>/workspace the way a reconnect does, nothing of Spinbox's
run first. Each case runs in bubblewrap with a home of its own over $HOME
(ssh reads ~/.ssh from the password database), a wrapper around spin that
stamps each call, and a probe extension that says what the window is
connected to, runs a command in its terminal, and closes notifications when
asked. Every check is read from VS Code's logs, the probe and the stack:
- running and stopped: Spinbox activates on onResolveRemoteAuthority:
ssh-remote, its spin code --start ends before Remote-SSH's resolver is
called, the workspace (stopped one included) is running, and the
terminal's command is read back with spin exec;
- unenrolled: Spinbox shows key_not_enrolled, Remote-SSH never resolves,
and the window leaves the remote once the message is closed.
The unenrolled case fails on main: closing the message lets activation
resolve, and VS Code then calls Remote-SSH's resolver while the window
unloads, which runs into spin's askpass box, times out after ConnectTimeout,
and shows Remote-SSH's own "Could not establish connection" dialog; the
window is local only 17-85 s later (four runs). Holding activation instead leaves the
unload waiting on the resolution forever (join.disconnectRemote), so it is
not a fix.
It needs a stack and bwrap, so no workflow runs it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sfw check holds every package.json outside testdata to pnpm; the probe is an extension VS Code loads, never installed, as testdata/resolver is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
task test:remote-ssh(SPIN_STACK= aftertask e2e:up+task e2e:workspaces) installs the packaged VSIX and Marketplace Remote-SSH 0.128.0 into VS Code stable 1.146.0. It then opensvscode-remote://ssh-remote+spin.<ws>/workspacethe way a reconnect does.Results against main:
spin code --startends before Remote-SSH's resolver is called; the stopped workspace is started, and a terminal command runs in the workspace.The fix is #32 (
connect.tsand the case's assertions) with spin-stack/spin#1182.🤖 Generated with Claude Code