Skip to content

test: Remote-SSH in a real VS Code against a spin e2e stack - #31

Merged
aledbf merged 2 commits into
mainfrom
remote-ssh-lane
Nov 12, 2026
Merged

aledbf merged 2 commits into
mainfrom
remote-ssh-lane

Conversation

@aledbf

@aledbf aledbf commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

task test:remote-ssh (SPIN_STACK= after task e2e:up + task e2e:workspaces) installs the packaged VSIX and Marketplace Remote-SSH 0.128.0 into VS Code stable 1.146.0. It then opens vscode-remote://ssh-remote+spin.<ws>/workspace the way a reconnect does.

  • Every case runs in bubblewrap with its own home over $HOME.
  • Every check reads VS Code's logs, a wrapper that timestamps each spin call, a probe extension, and the stack.
  • It needs a stack and bwrap, so no workflow runs it.

Results against main:

  • running and stopped pass. Spinbox's spin code --start ends before Remote-SSH's resolver is called; the stopped workspace is started, and a terminal command runs in the workspace.
  • unenrolled fails. Spinbox shows key_not_enrolled, and Remote-SSH waits while the message is up. Once the message closes, Remote-SSH still resolves: its ssh runs into spin's askpass box and times out, it shows its own error, and the window takes 17–85 s to leave the remote.

The fix is #32 (connect.ts and the case's assertions) with spin-stack/spin#1182.

🤖 Generated with Claude Code

aledbf and others added 2 commits November 12, 2026 20:03
task test:remote-ssh installs the packaged VSIX and Microsoft's Remote-SSH
from the Marketplace into VS Code stable and opens vscode-remote://
ssh-remote+spin.<ws>/workspace the way a reconnect does, nothing of Spinbox's
run first. Each case runs in bubblewrap with a home of its own over $HOME
(ssh reads ~/.ssh from the password database), a wrapper around spin that
stamps each call, and a probe extension that says what the window is
connected to, runs a command in its terminal, and closes notifications when
asked. Every check is read from VS Code's logs, the probe and the stack:

  - running and stopped: Spinbox activates on onResolveRemoteAuthority:
    ssh-remote, its spin code --start ends before Remote-SSH's resolver is
    called, the workspace (stopped one included) is running, and the
    terminal's command is read back with spin exec;
  - unenrolled: Spinbox shows key_not_enrolled, Remote-SSH never resolves,
    and the window leaves the remote once the message is closed.

The unenrolled case fails on main: closing the message lets activation
resolve, and VS Code then calls Remote-SSH's resolver while the window
unloads, which runs into spin's askpass box, times out after ConnectTimeout,
and shows Remote-SSH's own "Could not establish connection" dialog; the
window is local only 17-85 s later (four runs). Holding activation instead leaves the
unload waiting on the resolution forever (join.disconnectRemote), so it is
not a fix.

It needs a stack and bwrap, so no workflow runs it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sfw check holds every package.json outside testdata to pnpm; the probe is
an extension VS Code loads, never installed, as testdata/resolver is.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@aledbf
aledbf merged commit a0e7294 into main Nov 12, 2026
3 checks passed
@aledbf
aledbf deleted the remote-ssh-lane branch November 12, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant