Repository navigation
release: the release prints and publishes the signing key; a key KMS would not self-sign is refused - #5
Merged
Conversation
…would not self-sign is refused Printing the key has KMS sign its user id, and only the release's role may sign: an administrator's public printed half a key, because go-crypto drops the signer's error. New now refuses that key with what KMS said, and the release writes the key beside what it signs, as terraform-provider-spin_signing-key.asc, and into its log. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Printing the public key requires KMS to sign the key's user id (the OpenPGP self-signature), and the key policy (ci#18) lets only the release role sign. With an administrator's credentials,
kmspgp publicprinted half a key: go-crypto drops the signer's own error and serializes an unsigned self-signature.kmspgp.Newnow refuses that key and says what KMS answered (test: a KMS that returns the public key but refuses to sign).public -out <file>.release.ymlprints the key in its log and GoReleaser attaches it to the release asterraform-provider-spin_signing-key.asc. The registries get the key from there: tag first, then register the key, then publish the provider (both registries read the releases that already exist).The fingerprint is the public key's plus the creation time, with no signature involved, so the one printed earlier (
8EF62E80E6B0A4DA9E7F7D2FD126D64FEE202416) is the one the release will print.mutate: 0 survived.🤖 Generated with Claude Code