Repository navigation
bootstrap: the publish role starts, reads and ends a check of its own images - #128
Merged
Merged
Conversation
… images spin-stack/ami#148 boots each role's image once on EC2 before its images.json pull request is opened: UEFI, NitroTPM and IMDSv2 are only what EC2 says they are. The role may start an instance of this account's own images, with no instance profile, tagged spin-os:check as it starts, and read its console and terminate it by that tag only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aledbf
force-pushed
the
publish-launch-check
branch
from
November 17, 2026 11:57
79ddd32 to
88f6662
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For spin-stack/ami#148: a release boots each role's AMI once in its region before the
images.jsonpull request is opened, and reads back from EC2 and the serial console what only EC2 can say: UEFI, NitroTPM, IMDSv2 required, and spin-boot taking its credentials from the real IMDS.The publish role (
<repo>-publish) gains a second inline policy,launch-check:ec2:RunInstancesfor an instance, volume and network interface only withspin-os:check=truerequested as a tag; from an image this account owns (ec2:Owner); into the account's subnets and security groups (the default VPC).ec2:CreateTagsonly as part ofRunInstances(ec2:CreateAction).ec2:DescribeInstances.ec2:GetConsoleOutputandec2:TerminateInstancesonly on instances taggedspin-os:check=true. The role can't read or end anything it didn't start.iam:PassRole: the check runs with no instance profile.This needs an apply of bootstrap in the publishing account before the ami side can use it. The ami change adding the release step waits for that apply, so no release fails on a missing permission.
task lintgreen. The deprecation warnings in its output are frommodules/controlplane/boot_log.tf(#125), fixed separately.🤖 Generated with Claude Code