Skip to content

qboot: no walk of the PCI bus - #285

Merged
aledbf merged 1 commit into
mainfrom
qboot-no-pci-walk
Nov 19, 2026
Merged

aledbf merged 1 commit into
mainfrom
qboot-no-pci-walk

Conversation

@aledbf

@aledbf aledbf commented Nov 19, 2026

Copy link
Copy Markdown
Member

qboot walked the PCI bus at every boot. It read each function's interrupt pin and class, wrote an INTx line into PCI_INTERRUPT_LINE, and numbered bridges. It never assigned BARs; Linux does.

Nothing on this machine reads what the walk left:

  • Linux routes interrupts from ACPI's _PRT;
  • every device it drives uses MSI-X;
  • bus 0 has no bridge.

The walk was 173 configuration-space exits: 5.0 ms nested against 2.2 on metal (boot:firmware-stages, labs 44535161371 and 44535156851).

qemu/qboot/no-pci-walk.patch keeps the chipset check, MMCONFIG and the BIOS32 entry, and drops the walk. The qboot stage asserts the patch is in the tree it compiled, as it does for the other three. The release ships it with them.

Checked locally on the built QEMU: boot:firmware (qboot boots, vmgenid is published, and a restore reseeds), boot:roms, boot:logind, boot:hotadd and boot:lockdown all pass. The bench measurement follows (boot:firmware-stages with this PR's QEMU beside the release's).

🤖 Generated with Claude Code

qboot read each function's interrupt pin and class, wrote an INTx line
into PCI_INTERRUPT_LINE and numbered bridges; it never assigned BARs.
Nothing here reads what it left: Linux routes interrupts from ACPI's
_PRT, every device it drives uses MSI-X, bus 0 has no bridge. The walk
was 173 config-space exits, 5.0 ms nested against 2.2 on metal
(boot:firmware-stages, labs 44535161371, 44535156851). The build
asserts the patch is in the tree it compiled; boot:firmware (vmgenid,
restore), boot:roms, boot:logind, boot:hotadd and boot:lockdown pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@aledbf
aledbf merged commit 4210fd9 into main Nov 19, 2026
3 checks passed
@aledbf
aledbf deleted the qboot-no-pci-walk branch November 19, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant