Repository navigation
qboot: no walk of the PCI bus - #285
Merged
Merged
Conversation
qboot read each function's interrupt pin and class, wrote an INTx line into PCI_INTERRUPT_LINE and numbered bridges; it never assigned BARs. Nothing here reads what it left: Linux routes interrupts from ACPI's _PRT, every device it drives uses MSI-X, bus 0 has no bridge. The walk was 173 config-space exits, 5.0 ms nested against 2.2 on metal (boot:firmware-stages, labs 44535161371, 44535156851). The build asserts the patch is in the tree it compiled; boot:firmware (vmgenid, restore), boot:roms, boot:logind, boot:hotadd and boot:lockdown pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qboot walked the PCI bus at every boot. It read each function's interrupt pin and class, wrote an INTx line into
PCI_INTERRUPT_LINE, and numbered bridges. It never assigned BARs; Linux does.Nothing on this machine reads what the walk left:
_PRT;The walk was 173 configuration-space exits: 5.0 ms nested against 2.2 on metal (
boot:firmware-stages, labs 44535161371 and 44535156851).qemu/qboot/no-pci-walk.patchkeeps the chipset check, MMCONFIG and the BIOS32 entry, and drops the walk. The qboot stage asserts the patch is in the tree it compiled, as it does for the other three. The release ships it with them.Checked locally on the built QEMU:
boot:firmware(qboot boots, vmgenid is published, and a restore reseeds),boot:roms,boot:logind,boot:hotaddandboot:lockdownall pass. The bench measurement follows (boot:firmware-stageswith this PR's QEMU beside the release's).🤖 Generated with Claude Code