Repository navigation
api-errors: the alert counts the server's failures, not callers told no - #12
Merged
Merged
Conversation
The High API Error Rate alert now counts INTERNAL, UNAVAILABLE, UNKNOWN, DATA_LOSS, and DEADLINE_EXCEEDED on anything but WaitWorkspace and WaitSnapshot (spin-stack/spin#1278). The runbook says so, names the codes it does not count, and drops the two fixes for answers it no longer counts (a client looping on UNAUTHENTICATED, a CLI of another release refused with FAILED_PRECONDITION). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For spin-stack/spin#1278: the High API Error Rate alert and the API error rate panels count only the server's failures (
INTERNAL,UNAVAILABLE,UNKNOWN,DATA_LOSS, andDEADLINE_EXCEEDEDon anything butWaitWorkspaceandWaitSnapshot).NOT_FOUND,UNAUTHENTICATED,FAILED_PRECONDITIONand the rest are the API answering.The runbook says what is counted, renames the panel it points to (Answers other than OK), and drops the two fixes for answers the alert no longer counts. The spin PR bumps its
runbookspin to this commit.🤖 Generated with Claude Code