extension: prove ownership for participant color updates#307
Draft
spencerc99 wants to merge 2 commits into
Draft
extension: prove ownership for participant color updates#307spencerc99 wants to merge 2 commits into
spencerc99 wants to merge 2 commits into
Conversation
commit: |
Owner
Author
Code review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
A public
pk_identifier is a public key, not authorization. The worker now verifies the corresponding private-key signature before accepting a color update.Verification
bun run testinextension/worker(46 tests)bun run test --runinextension(339 tests)bun run testinpackages/playhtml(361 tests)bun run testinpackages/react(43 tests)bun run build-packagesbunx wxt buildinextensionbun run deploy --dry-runinextension/workerPR #264 overlap
#264 is still open and adds a broader PlayHTML auth protocol. This PR intentionally uses the existing extension ECDSA identity storage and a worker-local request format, without importing #264's unreleased common auth contract. The only conceptual overlap is shared P-256 identity usage; the changed files do not overlap #264's extension files (
background.ts,content.ts).No
extension/PENDING.mdentry: this is a transparent security hardening change, not user-facing shipped behavior.