Fix stale archive filter results - #302
Draft
spencerc99 wants to merge 1 commit into
Draft
Conversation
Deploying we-were-online-website with
|
| Latest commit: |
3e2808e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c6b84da7.we-were-online-website.pages.dev |
| Branch Preview URL: | https://cx-fix-archive-filter-race.we-were-online-website.pages.dev |
Owner
Author
Code reviewNo issues found. Checked for bugs and project-instruction compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Each request could update event state and fetch bookkeeping after it awaited its network response, even if a later filter request had already replaced the active context.
Validation
bun run build-packagesbun run test --run(341 tests)bun run buildinextension/websitebun run lintinextension/websitereaches TypeScript successfully but then fails because the installed ESLint 9 toolchain cannot find a flat config.Integration
origin/feat/installation-multiscreenextracts this same fetch logic touseArchiveEvents; apply the same generation guard there when integrating so the refactor does not reintroduce the race.