binary(tests,spec-specs): add binary trees to forks/amsterdam using a --state-trie flag - #42
Draft
spencer-tb wants to merge 4 commits into
Draft
binary(tests,spec-specs): add binary trees to forks/amsterdam using a --state-trie flag#42spencer-tb wants to merge 4 commits into
forks/amsterdam using a --state-trie flag#42spencer-tb wants to merge 4 commits into
Conversation
forks/amsterdam using a --state-trie flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Merges the binary trie infrastructure of
projects/binary-trie, and deliberately nothing the EIP process governs. The pain of a long lived project branch is rebasing churn and running a separate release pipeline, the latter creates confusion and burden for client teams tracking extra branches. Releases should be in one place with one work stream.Releases
The future release story here is to include the binary fixtures under the same release tag (branch/spec) as the mainnet/testnet releases & future devnet releases for H*. Following the strawmap, binary is proposed for I*/J*, streamlining this process earlier within our releases allows development to be more clean. Each release would now have:
fixtures_hegota-devnet.tar.gz&fixtures_hegota-devnet_binary.tar.gzfixtures.tar.gz&fixtures_binary.tar.gzKey Notes
src/ethereum/forks/. No fork copy, no pseudo-fork, no EIP-8297 semantics in any fork. The spec's fork lineage (and its rendered docs) remains exactly the set of scheduled forks. Abinary_treefork materializes if and when the EIP process schedules 8297.partitioned_binary_tree.pyvsmerkle_patricia_trie.pyandstate_pbt.pyvsstate_mpt.py. These are selected per session by a testing flag. A tooling property, not a protocol property.The only item that should be remaining on
projects/binary-trieare the non STF vectors, which are removed from this PR.Other Additions vs
projects/binary-triebinary-triejob, unit tests with coverage plus a full-tree PBT filljust fill-state-trie-pbt, mirroring the defaultfillrecipe in the Justfile.fixtures_binary.tar.gzon everytests@/<feat>-devnet@tag (variants:infeature.yaml. The same feature will be added for zkevm.test_state_trie_option_sets_and_resets_the_override:--state-triesets the session override and unconfigure resets ittest_build_result_reports_uncommittable_state_as_rejected: the t8n reports uncommittable state as a rejected block with the pre state roottest_get_code_contract_is_identical_across_providers: MPT and PBT providers share the sameget_codeerror contract--state-trie {mpt,pbt}session flag replaces theBinaryTreepseudo-fork, the fork class is gone and all commitment tests are fork-agnostic against the flagethereum/binary_trie/package collapsed into a singleethereum/partitioned_binary_tree.py, mirroringmerkle_patricia_trie.py, with the module docstring rewritten, prose cleanup throughoutRelated Issues or PRs
N/A.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture