fix(test-specs): Review fixes for implicit transaction gas-limit - #14
Closed
spencer-tb wants to merge 3 commits into
Closed
fix(test-specs): Review fixes for implicit transaction gas-limit#14spencer-tb wants to merge 3 commits into
spencer-tb wants to merge 3 commits into
Conversation
spencer-tb
force-pushed
the
implicit-gas-limit-fixes
branch
4 times, most recently
from
June 12, 2026 14:50
305d2a3 to
f2d3252
Compare
spencer-tb
force-pushed
the
implicit-gas-limit-fixes
branch
from
June 12, 2026 14:51
f2d3252 to
652c815
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dummy review PR — fixes for upstream ethereum#2969 (
marioevz/implicit-gas-limit), staged here for diff review before pushing to the upstream PR branch.Fixes
Transactiontreatsgas_limit=Noneas unset (before-validator) — fixes the fill crashes in the EIP-6110/7002/7251 helpers andgas_test(); unit test added.test_sstore_state_gas_all_tx_typespinsstate_gas_reservoir=0to keep per-type zero-reservoir spill coverage.many_deposits_from_contract_oogun-xfailed: explicit 10M limit restored, raised per fork to the EIP-7623/EIP-8037 calldata floor.gas_limitNone-checks removed (field is non-Optional).Verification
Filled across full fork ranges: deposits dir 450, 7002+7251 566,
gas_testcallers 4199 (Frontier→Amsterdam), modexp trio 144 (Cancun→Amsterdam), 8037 sstore + misc 682. Framework unit suites andjust staticpass.