fix(navigator): resolve symbol usages and prevent repetitive items - #22
Merged
Merged
Conversation
added 3 commits
September 17, 2026 21:48
…ilepaths - Remove erroneous OR source_symbol_id condition that classified outgoing calls as incoming callers - Join ast_symbols to resolve target_filepath and target_symbol_id for outgoing callees - Group repeated caller and callee occurrences by symbol and provide call_count and all_lines - Prioritize resolved internal codebase symbols to the top of callees list - Scope queries to repo and tighten file outline filepath matching
…counts in inspector - Make callee items clickable when target_filepath is present with Jump indicator and keyboard support - Display call_count and multiple line numbers for grouped calls and imports - Update types and CSS for clickable callee items and badges - Add test coverage for onSelectCallee cross-file navigation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes the Codebase Navigator.
The list previously showed the same symbol multiple times.
The list also failed to open target files when users clicked symbol dependencies.
Problem Description
Because of this error, the list showed the current symbol many times.
Therefore, users could not click a callee to open its file.
Symbols from different files with identical names appeared in one outline.
Solution and Technical Changes
Fix Incoming Callers Query (
app/services/navigator.py):Resolve Target File Paths for Callees (
app/services/navigator.py):ast_symbolstable to resolve the file path of each callee.Group Repeated Calls (
app/services/navigator.py,NavigatorInspector.tsx):Add Callee Click Navigation (
NavigatorInspector.tsx,navigator.css):Tighten Outline Path Matching (
app/services/navigator.py):Verification
Backend Tests:
pytest tests/backend/test_navigator_service.py tests/backend/test_navigator_router.py.app/services/navigator.pyandapp/api/routers/navigator.py.Frontend Tests:
vitest run src/tests/Navigator* src/tests/CodeNavigator.test.tsx.