Skip to content

Fix STEREO crib magnetic field load - #418

Open
huangzesen wants to merge 1 commit into
spedas:masterfrom
huangzesen:fix/bleeding-edge-21-st-crib-mag-load
Open

Fix STEREO crib magnetic field load#418
huangzesen wants to merge 1 commit into
spedas:masterfrom
huangzesen:fix/bleeding-edge-21-st-crib-mag-load

Conversation

@huangzesen

Copy link
Copy Markdown

Summary

  • remove the unsupported TYPE keyword from the STEREO crib st_mag_load call
  • request the intended/default 8 Hz magnetic-field resolution explicitly

Fixes #21

Validation

  • rg -n 'st_mag_load,type' idl/general/missions/stereo/st_crib.pro returns no matches
  • checked st_mag_load signature: it accepts resolution=res and defaults res to '8hz'

Review

  • Zhipu/GLM review gate: reviewed before PR; no blocking findings; explicit resolution='8hz' polish applied

@jameswilburlewis

Copy link
Copy Markdown
Contributor

This looks like a plausible fix; however, we don't have a mechanism to propagate Github pull requests back to the Subversion repository used for IDL SPEDAS development. This Github repo is periodically refreshed from the SVN branch, but there is no process to mirror updates going the other way. We would recommend using a valid SSH key to access the SVN repository on ambrosia.ssl.berkeley.edu via an svn+ssh: URL. It would be best to create a short-lived branch from the SVN trunk for each IDL SPEDAS issue, perform any updates there, then email one of the SPEDAS maintainers with a request to review the changes and merge the updates into the trunk.

@huangzesen

Copy link
Copy Markdown
Author

Thanks, Jim — understood. I appreciate the clarification that this GitHub repository is refreshed from the IDL SPEDAS SVN branch and that GitHub PRs do not currently propagate back into SVN.

I'll treat this PR and the related bleeding_edge PRs as patch/review artifacts rather than the final upstreaming path. We'll follow up through the SVN workflow you described — short-lived branches from the SVN trunk via svn+ssh on ambrosia.ssl.berkeley.edu, then maintainer review/merge by email — once we have the appropriate access/workflow details in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

STEREO crib st_crib.pro with unsupported keyword

2 participants