validator: allow pack values.yaml to add cpu/memory resource limits - #321
Open
vishwanaths wants to merge 1 commit into
Open
validator: allow pack values.yaml to add cpu/memory resource limits#321vishwanaths wants to merge 1 commit into
vishwanaths wants to merge 1 commit into
Conversation
check-values-structure.py rejected any key present in a pack's values.yaml but absent from the chart's own values.yaml, including the common case of a pack adding a resources.limits.cpu or resources.limits.memory override that the chart doesn't define by default. Tightening resource limits at the pack level is an intentional, allowed override, not a structural defect, so it should not fail validation. Ported from the same fix in spectrocloud/pax (PR #4635). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Medhakulam
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check-values-structure.py's structural subset check rejected any key present in a pack'svalues.yamlbut absent from the chart's ownvalues.yaml— including the common, intentional case of a pack adding aresources.limits.cpuorresources.limits.memoryoverride that the chart doesn't ship by default.limitsand the missing key iscpuormemory, it's allowed. All other structural mismatches (renamed/removed keys, other added keys,requests.*, etc.) still fail exactly as before.spectrocloud/pax#4635, surfaced there by acsi-aws-ebspack that setslimits.cpuwhile its chart only defineslimits.memory.Test plan
limits.cpu/limits.memorypass; unrelated added keys and addedrequests.cpustill correctly fail.Packs Validation) passes on this PR.🤖 Generated with Claude Code