Skip to content

NVIDIA Network Operator 26.7.0 - #312

Open
kreeuwijk wants to merge 3 commits into
mainfrom
nvidia-network-operator-2670
Open

NVIDIA Network Operator 26.7.0#312
kreeuwijk wants to merge 3 commits into
mainfrom
nvidia-network-operator-2670

Conversation

@kreeuwijk

Copy link
Copy Markdown
Contributor

Container images haven't published by NVIDIA yet, waiting for those to become available

@kreeuwijk kreeuwijk added the do-not-merge Not yet ready to be merged label Aug 26, 2026
@vishwanaths

vishwanaths commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

Pack review — network-operator-26.7.0 (repo: spectrocloud/pack-central)

Packs Validation: ❌ FAILURE (run rerun of https://github.com/spectrocloud/pack-central/actions/runs/32960320154) — genuine content issue, invalid image tags (see Blockers)
source annotation: ✅ community matches expected community
Pack metadata: name=network-operator version=26.7.0 addonType=system app layer=addon displayName=NVIDIA Network Operator contributor=spectrocloud

Compared against packs/nvidia-network-operator-26.1.0/

26.7.0 is the highest version on main for this pack (prior versions on main: 25.7.0, 25.10.0, 26.1.0) — no back-port concern.

Summary of differences

  • pack.json: version bumped 26.1.026.7.0; .charts entry updated to charts/network-operator-26.7.0.tgz; displayName casing changed "Nvidia Network Operator""NVIDIA Network Operator".
  • values.yaml:
    • ~20 image tags bumped from network-operator-v26.1.0network-operator-v26.7.0 (nfd, cloud-native/network-operator, init-container, maintenance-operator, sriov-*, etc.).
    • New image added: sriovDraDriver: nvcr.io/nvidia/mellanox/dra-driver-sriov:network-operator-v26.7.0.
    • Previously-commented-out kube-rbac-proxy image replaced with an active reference: quay.io/brancz/kube-rbac-proxy:v0.21.2.
    • New tunables added for graceful node shutdown handling: keepNCP, priorityClassName: system-node-critical, terminationGracePeriodSeconds: 30, preStopSleepSeconds: 25.
    • New coverage.enabled: false toggle added.
    • upgradeController.requestorID changed from nvidia.network-operator-driver-upgrade-controllernvidia.doca-driver-upgrade.
    • Commented-out doca-driver image tags bumped from doca3.3.0-26.01-...doca3.4.1-26.04-....
  • charts: network-operator-26.7.0.tgz 126278 → 138803 bytes (+12525 bytes, ~+9.9%), consistent with new sriov-network-operator CRDs/templates and dra-driver subchart additions.
  • logo.png: unchanged (identical blob hash).
  • Files added/removed: none — top-level file set unchanged (README.md, charts/, logo.png, pack.json, values.yaml).

pack.json diff

-    "displayName": "Nvidia Network Operator",
+    "displayName": "NVIDIA Network Operator",
     "charts": [
-      "charts/network-operator-26.1.0.tgz"
+      "charts/network-operator-26.7.0.tgz"
     ],
     "layer":"addon",
     "name": "network-operator",
-    "version": "26.1.0"
+    "version": "26.7.0"

values.yaml diff (truncated — see Files tab for full diff)

-      - image: nvcr.io/nvidia/mellanox/node-feature-discovery:network-operator-v26.1.0
-      - image: nvcr.io/nvidia/cloud-native/network-operator:v26.1.0
+      - image: nvcr.io/nvidia/mellanox/node-feature-discovery:network-operator-v26.7.0
+      - image: nvcr.io/nvidia/cloud-native/network-operator:v26.7.0
       ... (all network-operator-v26.1.0 → v26.7.0 tag bumps, ~20 lines)
+      - image: nvcr.io/nvidia/mellanox/dra-driver-sriov:network-operator-v26.7.0
-      #- image: gcr.io/kubebuilder/kube-rbac-proxy:v0.15.0
+      - image: quay.io/brancz/kube-rbac-proxy:v0.21.2
+      keepNCP: true
+      priorityClassName: system-node-critical
+      terminationGracePeriodSeconds: 30
+      preStopSleepSeconds: 25
+      coverage:
+        enabled: false
-        requestorID: "nvidia.network-operator-driver-upgrade-controller"
+        requestorID: "nvidia.doca-driver-upgrade"
         images:
-          sriovCni/ibSriovCni/ovsCni/rdmaCni/sriovDevicePlugin/webhook: ...v26.1.0
+          sriovCni/ibSriovCni/ovsCni/rdmaCni/sriovDevicePlugin/webhook: ...v26.7.0
+          sriovDraDriver: nvcr.io/nvidia/mellanox/dra-driver-sriov:network-operator-v26.7.0

(diff truncated — see Files tab for full diff)

Naming drift (informational)

  • None found. charts/network-operator-26.7.0.tgz's Chart.yaml name is network-operator, matching this pack's pack.json.name (network-operator), consistent with all prior versions (25.7.0, 25.10.0, 26.1.0).
  • Reverse scan across packs/ (237 pack dirs on main) for any other pack wrapping a chart named network-operator found none — sriov-network-operator-{1.5.0,1.6.0} is a distinct, correctly-named separate pack, not a collision.

Blockers

  • Packs Validation — invalid image tags: The workflow was re-run (the earlier attempt failed on an unrelated apt-get/packages.microsoft.com 403 during tool install, which is fixed on rerun). With the installer working, the Check Packs step ran and found 16 image references in values.yaml that don't resolve — the tag network-operator-v26.7.0 does not exist upstream for these nvcr.io/nvidia/mellanox/* images (MANIFEST_UNKNOWN):
    sriov-network-operator-config-daemon, sriov-network-device-plugin, sriov-network-operator-webhook, sriov-cni, dra-driver-sriov, ib-sriov-cni, ovs-cni-plugin, rdma-cni, nic-configuration-operator, nic-configuration-operator-daemon, spectrum-x-operator, nvidia-k8s-ipam, k8s-rdma-shared-dev-plugin, ipoib-cni, plugins, multus-cni.
    This needs a fix before merge — either these images ship under a different tag upstream for the 26.7.0 release (most likely — worth checking NVIDIA's release notes/registry for the correct tag scheme) or the version bump is incomplete/premature.

Nits / observations

  • displayName casing changed from "Nvidia Network Operator" (26.1.0) to "NVIDIA Network Operator" (26.7.0). Cosmetic, but worth keeping consistent going forward.
  • Two other checks on this PR are also red: gitleaks-scan (BulwarkGitLeaks) and security-scans/pax-cve (spectrocloud/bulwark). These are outside the scope of Packs Validation and this review, but a maintainer may want to confirm they aren't blocking merge for unrelated reasons.

Validator output section omitted — the Check Packs step never ran (skipped due to the tool-install failure above), so no SUCCESS:/ERROR: lines were emitted to extract.

Review generated by the pack-reviewer Claude Code subagent.

@kreeuwijk kreeuwijk removed the do-not-merge Not yet ready to be merged label Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants