Skip to content

Disable Series Data Entry when 'isCurrent' and 'isPrimary' can be misassigned#7182

Merged
CarolineDenis merged 5 commits into
issue-7144from
bulk-temp-fix
Jul 24, 2025
Merged

Disable Series Data Entry when 'isCurrent' and 'isPrimary' can be misassigned#7182
CarolineDenis merged 5 commits into
issue-7144from
bulk-temp-fix

Conversation

@alesan99
Copy link
Copy Markdown
Contributor

@alesan99 alesan99 commented Jul 23, 2025

Temporary fix for #5022 for Series Entry.

Disables Bulk Carry Forward Range if you have more than one record on the following dependent relationships:

  • determinations
  • determiners
  • collectors
  • funding agents (probably not possible here, Collecting Trips are not dependent)
  • addresses (probably not possible here, Agents are not dependent)

Bulk Carry Forward Count is unchanged by this PR.

image

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests

Testing instructions

  • Go to Data Entry for Collection Object
  • Enable Bulk Carry Forward Range
  • Verify bulk carry forward is disabled for the following cases:
  • If you have more than 1 determination
  • If you have more than 1 determiner in any determinations
  • If you have more than 1 collector in a Collecting Event
  • If your CO is part of a consolidated COG (Other COGTypes should work, and number of records doesn't matter for this).
  • Make sure you can bulk carry forward normally if none of the above are true.
  • Make sure Bulk Carry Forward works as expected on COs in non-consoldiated COGs.

@alesan99 alesan99 changed the title Disable Series Data Entry when cloning is bugged Disable Series Data Entry when 'isCurrent' and 'isPrimary' can be misassigned Jul 23, 2025
@alesan99 alesan99 marked this pull request as ready for review July 23, 2025 19:44
@alesan99
Copy link
Copy Markdown
Contributor Author

alesan99 commented Jul 23, 2025

Ready for testing now!

@alesan99 alesan99 requested review from a team July 23, 2025 19:47
Copy link
Copy Markdown
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • If you have more than 1 determination
  • If you have more than 1 determiner in any determinations
  • If you have more than 1 collector in a Collecting Event
  • If you have more than 1 funding agent in a Collecting Trip
  • Make sure you can bulk carry forward normally if none of the above are true.

Screenshot 2025-07-23 at 3 27 30 PM

Bugs

1. Bulk carry is not disabled when there is more than 1 funding agent in a Collecting Trip.
Record set (not same as video, just similar on test panel): https://calvertmarinemuseumgen20250721-bulk-temp-fix.test.specifysystems.org/specify/view/collectionobject/26348/?recordsetid=166
https://github.com/user-attachments/assets/4a0e5365-324a-4c73-a0d0-6e869856aba1
Collection: Invertebrates
Username: spadmin

Screen.Recording.2025-07-23.at.4.19.06.PM.mov

@github-project-automation github-project-automation Bot moved this from 📋Back Log to Dev Attention Needed in General Tester Board Jul 23, 2025
@pashiav pashiav requested a review from a team July 23, 2025 21:55
@alesan99
Copy link
Copy Markdown
Contributor Author

1. Bulk carry is not disabled when there is more than 1 funding agent in a Collecting Trip. Record set (not same as video, just similar on test panel):

That's my mistake, Collecting Trips aren't dependent on Collecting Events, so they won't be cloned when you Carry Forward a Collection Object.
Updated the testing instructions!


Also pushed a fix for Consolidated COGs. The isPrimary checkbox would also get misassigned when the cojo would get cloned.
Added to the testing instructions 👍

image

@alesan99 alesan99 requested a review from pashiav July 24, 2025 13:08
Copy link
Copy Markdown
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • If you have more than 1 determination
  • If you have more than 1 determiner in any determinations
  • If you have more than 1 collector in a Collecting Event
  • If your CO is part of a consolidated COG (Other COGTypes should work, and number of records doesn't matter for this).
  • Make sure you can bulk carry forward normally if none of the above are true.
  • Make sure Bulk Carry Forward works as expected on COs in non-consoldiated COGs.

Looks good, carry forward is blocked in all cases.

@emenslin emenslin requested a review from a team July 24, 2025 14:20
@CarolineDenis CarolineDenis requested a review from acwhite211 July 24, 2025 14:22
Copy link
Copy Markdown
Collaborator

@bhumikaguptaa bhumikaguptaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • If you have more than 1 determination
  • If you have more than 1 determiner in any determinations
  • If you have more than 1 collector in a Collecting Event
  • If your CO is part of a consolidated COG (Other COGTypes should work, and number of records doesn't matter for this).
  • Make sure you can bulk carry forward normally if none of the above are true.
  • Make sure Bulk Carry Forward works as expected on COs in non-consoldiated COGs.

works as expected.

@CarolineDenis CarolineDenis merged commit 1c9d603 into issue-7144 Jul 24, 2025
14 checks passed
@CarolineDenis CarolineDenis deleted the bulk-temp-fix branch July 24, 2025 15:29
@github-project-automation github-project-automation Bot moved this from Dev Attention Needed to ✅Done in General Tester Board Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

6 participants