ci: add NVIDIA workers and NVMf {RDMA,TCP} jobs#210
Conversation
mhae
left a comment
There was a problem hiding this comment.
It's not clear to me why we need to have a common workflow. This workflow is specific to HPE's VM and config (i.e. CX6 and actual NVMe drives).
I also don't want to run nvmf tcp on our VM.
I suggest we keep these jobs separate.
|
@mchomnic , remind me again what HW you are using? Is it ARM or x86? |
|
Hi @mhae, |
e8ae946 to
f9c3d4b
Compare
|
@mhae @tomzawadzki , I changed the approach. I added separated jobs for nvidia's jobs. WDYT? |
f9c3d4b to
2ab5f37
Compare
|
|
||
| jobs: | ||
| nvidia-nvmf-rdma: | ||
| runs-on: [nvidia-ubuntu-vm] |
There was a problem hiding this comment.
Can we re-label the runners to have more details or use more then one label? E.g. using [nvidia, x64, ubuntu-2404, vm] provides much more information at first glance.
There was a problem hiding this comment.
@mchomnic how about this one? It's much less effort re-labeling the runners now rather than doing it post-merge when there's builds queued up.
There was a problem hiding this comment.
Sure, I'm open for any changes. I just want to discuss it before I will update config, because I have already done twice.
What about [Linux, X86, ubuntu-2404, nvidia-vm, gen-vm]? @tomzawadzki
2ab5f37 to
06a40e3
Compare
Run NVMf RDMA and TCP jobs on NVIDIA Ubuntu VMs. Signed-off-by: Marek Chomnicki <mchomnicki@nvidia.com>
06a40e3 to
7699d83
Compare
Rename the nvmf-rdma job to vm-nvmf-rdma for generic rdma-vm workers and add a dedicated nvmf-tcp workflow.