Skip to content

ci: add NVIDIA workers and NVMf {RDMA,TCP} jobs#210

Open
mchomnic wants to merge 1 commit into
spdk:mainfrom
mchomnic:mch/workers-tests
Open

ci: add NVIDIA workers and NVMf {RDMA,TCP} jobs#210
mchomnic wants to merge 1 commit into
spdk:mainfrom
mchomnic:mch/workers-tests

Conversation

@mchomnic

@mchomnic mchomnic commented Jun 9, 2026

Copy link
Copy Markdown

Rename the nvmf-rdma job to vm-nvmf-rdma for generic rdma-vm workers and add a dedicated nvmf-tcp workflow.

@mchomnic mchomnic requested review from karlatec, mhae and tomzawadzki and removed request for mhae June 9, 2026 14:51

@mhae mhae left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me why we need to have a common workflow. This workflow is specific to HPE's VM and config (i.e. CX6 and actual NVMe drives).
I also don't want to run nvmf tcp on our VM.
I suggest we keep these jobs separate.

@mhae

mhae commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@mchomnic , remind me again what HW you are using? Is it ARM or x86?
I wonder if we should have specific runners based on HW vs "common" NVMF/RDMA runners.
What if you want to add some tests that uses a HW feature that HPE's runner doesn't have?
On the other hand, it would help with high availability....
Note, if we change labels, then I have to update and restart my runners.

@mchomnic

Copy link
Copy Markdown
Author

Hi @mhae,
The common workflow was a @tomzawadzki's suggestion as baseline to discussion.
The other options is to stay with separate label, eg: nvidia-rdma-vm (or something similar), but the consers was, do we want to run nvmf-rdma twice in per-patch.
I have x86 VMs with CX9 vfs and emulated nvme.

@mchomnic mchomnic force-pushed the mch/workers-tests branch from e8ae946 to f9c3d4b Compare June 16, 2026 14:21
@mchomnic mchomnic changed the title ci: rename RDMA job and add nvmf-tcp workflow ci: add NVIDIA workers and NVMf {RDMA,TCP} jobs Jun 16, 2026
@mchomnic

Copy link
Copy Markdown
Author

@mhae @tomzawadzki , I changed the approach. I added separated jobs for nvidia's jobs. WDYT?
P.S. Two nvidian's workers are already added to spdk/spdk-ci . I want to check the workflow.

@mchomnic mchomnic requested a review from mhae June 16, 2026 14:24
@mchomnic mchomnic force-pushed the mch/workers-tests branch from f9c3d4b to 2ab5f37 Compare June 16, 2026 14:26
Comment thread .github/workflows/nvidia-nvmf-rdma.yml Outdated
Comment thread .github/workflows/nvidia-nvmf-rdma.yml Outdated
Comment thread .github/workflows/nvidia-nvmf-rdma.yml Outdated
Comment thread .github/workflows/nvidia-nvmf-rdma.yml Outdated

jobs:
nvidia-nvmf-rdma:
runs-on: [nvidia-ubuntu-vm]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we re-label the runners to have more details or use more then one label? E.g. using [nvidia, x64, ubuntu-2404, vm] provides much more information at first glance.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mchomnic how about this one? It's much less effort re-labeling the runners now rather than doing it post-merge when there's builds queued up.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'm open for any changes. I just want to discuss it before I will update config, because I have already done twice.
What about [Linux, X86, ubuntu-2404, nvidia-vm, gen-vm]? @tomzawadzki

@mchomnic mchomnic force-pushed the mch/workers-tests branch from 2ab5f37 to 06a40e3 Compare June 16, 2026 19:41
Run NVMf RDMA and TCP jobs on NVIDIA Ubuntu VMs.

Signed-off-by: Marek Chomnicki <mchomnicki@nvidia.com>
@mchomnic mchomnic force-pushed the mch/workers-tests branch from 06a40e3 to 7699d83 Compare June 16, 2026 19:57
@mchomnic mchomnic requested a review from karlatec June 17, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants