Repository navigation
Replace define_aggregator's generated proxy class with a factory object - #752
Merged
Merged
Conversation
define_aggregator2 only needs a handler that responds to new and arity. Use a small object that clones the template for new, instead of generating a class whose instances just forwarded step and finalize to a clone of the template.
tenderlove
approved these changes
Oct 16, 2026
Member
|
@jhawthorn This shipped in v2.10.1. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
define_aggregator2 only needs a handler that responds to new and arity. Use a small object that clones the template for new, instead of generating a class whose instances just forwarded step and finalize to a clone of the template.
This is simpler and will work around a Ractor issue from #749