Set dataReady false for textures arrays in SplatPager#358
Open
mrxz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SplatPagerinitializes several texture arrays with newly created (zeroed) arrays. The default behaviour of Three.js is to upload this data to the GPU. In this case, however, there is no need as the data should never be accessed and the GPU initialized texture would already contain zero's either way. This PR sets thedataReadyflag to false, preventing Three.js from doing the initial upload. When a page needs to be uploaded, only the relevant layers are uploaded, so the superfluous upload is completely mitigated, not postponed.While making the above change, I got annoyed by the excessive duplication in
SplatPager. Resetting the flag needed to be repeated several times (once per SH texture x 2 forextSplatsand nonextSplats). As such, I've also replaced the individual sh-texture properties with an array, allowing creation, uploading and disposing to be handle by simple for-loops instead.