spdlog, hipblaslt: Fix spdlog 1.17.0 version pairing with fmt - #5802
Open
bernhardkaindl wants to merge 1 commit into
Open
spdlog, hipblaslt: Fix spdlog 1.17.0 version pairing with fmt#5802bernhardkaindl wants to merge 1 commit into
bernhardkaindl wants to merge 1 commit into
Conversation
A helpful comment in the spdlog package.py file explains the version pairing of spdlog and fmt. The comment explains that while spdlog can work with different versions of fmt, it is best to assume that the internal fmt version is the minimum version for compatibility. This change adds the missing version pairing for spdlog 1.17.0 with fmt. The spdlog package.py now depends on fmt 12.1 or later for spdlog 1.17.0 which is the recommended version pairing for spdlog 1.17.0 according to the comment in the spdlog package.py. Related to it, the last pull request for hipblaslt assumed that it has to ensure proper version pairing while as explained above it should leave this to the spdlog recipe. The pairing added in the pull request conflicts with all existin spdlog/fmt pairings, so it was to possible to concretize hipblaslt@7.1: anymore. Fix this by using a conflict for the fmt versions it does not support and leave the spdlog/fmt version pairing to the spdlog recipe. Fixes: 1769b89 spack#5467: "spdlog: add v1.17.0 && fmt: add v12.2.0" Fixes: 3e1fd73 spack#5309: "hipblaslt: Support air-gapped build"
spackbot-triage
Bot
requested review from
afzpatel,
renjithravindrankannath and
srekolam
July 30, 2026 07:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test the fix of a version conflict to pass the GitLab CI pipeline:
A helpful comment in the spdlog package.py file explains the version pairing of spdlog and fmt. The comment explains that while spdlog can work with different versions of fmt, it is best to assume that the internal fmt version is the minimum version for compatibility.
This change adds the missing version pairing for spdlog 1.17.0 with fmt. The spdlog package.py now depends on fmt 12.1 or later for spdlog 1.17.0 which is the recommended version pairing for spdlog 1.17.0 according to the comment in the spdlog package.py.
Related to it, the last pull request for hipblaslt assumed that it has to ensure proper version pairing while as explained above it should leave this to the spdlog recipe. The pairing added in the pull request conflicts with all existin spdlog/fmt pairings, so it was to possible to concretize hipblaslt@7.1: anymore.
Fix this by using a conflict for the fmt versions it does not support and leave the spdlog/fmt version pairing to the spdlog recipe.
Fixes: 1769b89 #5467: "spdlog: add v1.17.0 && fmt: add v12.2.0"
Fixes: 3e1fd73 #5309: "hipblaslt: Support air-gapped build"
conflicts("fmt@1.11", when="@7.1:", msg="rocroller in ROCm 7.1+ fails to build with fmt 11")which expresses the stated conflict, mentioned in the comment, best:In my current environment, hipblaslt also fails when using types like
uint32_tetc without includingstdint.h, so it adds-include stdint.hto work around this problem in the source files.The 1st hurdle of this PR is to pass GitLab CI: #5743 failed in the build of rocblas not finding
hipblas-common.