add cxxstd variant to camp - #5782
Draft
dtaller wants to merge 3 commits into
Draft
Conversation
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/camp/package.py
�[1;34m==> �[0mrunning ruff format
1 file reformatted
�[1;34m==> �[0mrunning ruff check
�[1m�[91mE501 �[0m�[1mLine too long (126 > 99)�[0m
�[1m�[94m-->�[0m repos/spack_repo/builtin/packages/camp/package.py:97:100
�[1m�[94m|�[0m
�[1m�[94m95 |�[0m variant("sycl", default=False, description="Build with Sycl support")
�[1m�[94m96 |�[0m
�[1m�[94m97 |�[0m # TODO: Add conflicts. I know that v2026.07.0 has concepts (C++20 feature) and cannot be built with earlier C++ versions.
�[1m�[94m|�[0m �[1m�[91m^^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m
�[1m�[94m98 |�[0m variant(
�[1m�[94m99 |�[0m "cxxstd",
�[1m�[94m|�[0m
Found 1 error.
I've updated the branch with style fixes. |
dtaller
marked this pull request as draft
July 29, 2026 15:43
Contributor
Author
|
Converting to draft. I think the cxxstd fix may need to go into packages that use camp's header files, such as axom |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most recent version of camp has concepts, a C++20 feature, so I added a variant to specify the version so I can build with spack.