Skip to content

kokkos-fft: add v2.0.0 - #5756

Open
tpadioleau wants to merge 1 commit into
spack:developfrom
tpadioleau:update-kokkos-fft
Open

kokkos-fft: add v2.0.0#5756
tpadioleau wants to merge 1 commit into
spack:developfrom
tpadioleau:update-kokkos-fft

Conversation

@tpadioleau

@tpadioleau tpadioleau commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@spackbot-triage spackbot-triage Bot added new-version Modifications to packages' `depends_on()` directives dependencies Modifications with a `depends_on()` directive update-package Modifications to packages in the repository labels Jul 27, 2026
@tpadioleau

tpadioleau commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

To the Spack reviewer, do you know why @yasahi-hpc cannot review the PR being one the maintainers of the package ?

@bernhardkaindl

bernhardkaindl commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Pleased to explain. 🙂

The reason is that @yasahi-hpc isn't currently a member of the GitHub Spack organisation. Even so, you can absolutely mention him using @yasahi-hpc, and he can still review the changes and leave comments with his feedback.

That said, regardless of organisation membership, a PR can only be merged after approval from a spack-packages repository maintainer. So even if he were added to the organisation, that alone wouldn't be sufficient for the PR to be merged.

If you'd like his feedback before the PR is merged, feel free to mention that here in the discussion so reviewers are aware of your preference. And if you want to make sure the PR cannot be merged until then, you can also use the "Convert to draft" option on the PR page. That clearly signals that you're still waiting for additional review and temporarily prevents the PR from being merged.

@alecbcs alecbcs changed the title kokkos-fft: add version 2.0.0 kokkos-fft: add v2.0.0 Jul 27, 2026
yasahi-hpc
yasahi-hpc approved these changes Jul 28, 2026
View reviewed changes

@yasahi-hpc yasahi-hpc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I can submit a review, thanks

yasahi-hpc
yasahi-hpc reviewed Jul 28, 2026
View reviewed changes
Comment thread repos/spack_repo/builtin/packages/kokkos_fft/package.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cedricchevalier19 cedricchevalier19 Awaiting requested review from cedricchevalier19
1 more reviewer
@yasahi-hpc yasahi-hpc yasahi-hpc approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

dependencies Modifications with a `depends_on()` directive new-version Modifications to packages' `depends_on()` directives update-package Modifications to packages in the repository

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tpadioleau @bernhardkaindl @yasahi-hpc