Skip to content

vasp: The +mpi variant of wannier90 3.x does not work with VASP - #5755

Open
nboelte wants to merge 4 commits into
spack:developfrom
gwdg:vasp/fix-wannier90
Open

vasp: The +mpi variant of wannier90 3.x does not work with VASP#5755
nboelte wants to merge 4 commits into
spack:developfrom
gwdg:vasp/fix-wannier90

Conversation

@nboelte

@nboelte nboelte commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@spackbot-triage spackbot-triage Bot added dependencies Modifications with a `depends_on()` directive update-package Modifications to packages in the repository labels Jul 27, 2026
@bernhardkaindl bernhardkaindl changed the title Fix wannier90 interface by requiring the serial variant vasp: The +mpi variant of wannier90 3.x does not work with VASP Jul 27, 2026
@snehring

snehring commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

It'd be better to only restrict wannier90~mpi when wannier90@3:

bernhardkaindl
bernhardkaindl reviewed Jul 28, 2026
View reviewed changes
Comment thread repos/spack_repo/builtin/packages/vasp/package.py Outdated
@spackbot-triage spackbot-triage Bot added conflicts Modifications with a `conflicts()` directive and removed dependencies Modifications with a `depends_on()` directive labels Jul 28, 2026
@nboelte

nboelte commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

@snehring I used a conflict instead to only restrict wannier90@3:

snehring
snehring reviewed Jul 28, 2026
View reviewed changes
Comment thread repos/spack_repo/builtin/packages/vasp/package.py Outdated
@nboelte @snehring
Update repos/spack_repo/builtin/packages/vasp/package.py
03b5bec 
Co-authored-by: snehring <7978778+snehring@users.noreply.github.com>
@spackbot-triage spackbot-triage Bot added dependencies Modifications with a `depends_on()` directive and removed conflicts Modifications with a `conflicts()` directive labels Jul 28, 2026
bernhardkaindl
bernhardkaindl reviewed Jul 28, 2026
View reviewed changes
Comment thread repos/spack_repo/builtin/packages/vasp/package.py Outdated
@nboelte @bernhardkaindl
Update repos/spack_repo/builtin/packages/vasp/package.py
a8dfaa2 
Co-authored-by: Bernhard Kaindl <bernhardkaindl7@gmail.com>
@spackbot-triage spackbot-triage Bot added conflicts Modifications with a `conflicts()` directive and removed dependencies Modifications with a `depends_on()` directive labels Jul 29, 2026
@snehring

snehring commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bernhardkaindl bernhardkaindl bernhardkaindl left review comments
+1 more reviewer
@snehring snehring snehring approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

conflicts Modifications with a `conflicts()` directive update-package Modifications to packages in the repository

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nboelte @snehring @bernhardkaindl