Skip to content

CP2K/DBCSR: Revise requirement for libxsmm, dftd4, and tblite - #5746

Open
Growl1234 wants to merge 5 commits into
spack:developfrom
Growl1234:cp2k
Open

CP2K/DBCSR: Revise requirement for libxsmm, dftd4, and tblite#5746
Growl1234 wants to merge 5 commits into
spack:developfrom
Growl1234:cp2k

Conversation

@Growl1234

@Growl1234 Growl1234 commented Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@spackbot-triage spackbot-triage Bot added dependencies Modifications with a `depends_on()` directive update-package Modifications to packages in the repository new-variant Modifications to packages' `variant()` directives labels Jul 25, 2026
@Growl1234

Growl1234 commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

@spackbot fix style

@spackbot-app

spackbot-app Bot commented Jul 25, 2026

Copy link
Copy Markdown

Let me see if I can fix that for you!

@spackbot-app

spackbot-app Bot commented Jul 25, 2026

Copy link
Copy Markdown

I was able to run spack style --fix for you!

spack style --fix 
repos/spack_repo/builtin/packages/cp2k/package.py
repos/spack_repo/builtin/packages/dbcsr/package.py
�[1;34m==> �[0mrunning ruff format
1 file reformatted, 1 file left unchanged
�[1;34m==> �[0mrunning ruff check
All checks passed!
�[1;34m==> �[0mstyle checks passed
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

mtaillefumier
mtaillefumier reviewed Jul 25, 2026
View reviewed changes
Comment thread repos/spack_repo/builtin/packages/cp2k/package.py Outdated
Comment thread repos/spack_repo/builtin/packages/cp2k/package.py
Comment thread repos/spack_repo/builtin/packages/dbcsr/package.py Outdated
@spackbot-triage
spackbot-triage Bot requested a review from mtaillefumier July 25, 2026 12:41
awvwgk
awvwgk reviewed Jul 27, 2026
View reviewed changes
Comment thread repos/spack_repo/builtin/packages/cp2k/package.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abussy abussy Awaiting requested review from abussy
@dev-zero dev-zero Awaiting requested review from dev-zero
@hfp hfp Awaiting requested review from hfp
@RMeli RMeli Awaiting requested review from RMeli
2 more reviewers
@awvwgk awvwgk awvwgk left review comments
@mtaillefumier mtaillefumier mtaillefumier approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

dependencies Modifications with a `depends_on()` directive new-variant Modifications to packages' `variant()` directives update-package Modifications to packages in the repository

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LIBXS + LIBXSMM dependency installation using Spack in cp2k@2026.2

3 participants

@Growl1234 @awvwgk @mtaillefumier