Skip to content

cmake: add v4.2.4, v4.3.4 - #5580

Merged
rbberger merged 1 commit into
spack:developfrom
rbberger:updates/cmake
Jul 28, 2026
Merged

cmake: add v4.2.4, v4.3.4#5580
rbberger merged 1 commit into
spack:developfrom
rbberger:updates/cmake

Conversation

@rbberger

Copy link
Copy Markdown
Member

No description provided.

@spackbot-triage spackbot-triage Bot added new-version Modifications to packages' `depends_on()` directives update-package Modifications to packages in the repository labels Jul 14, 2026
@spackbot-triage
spackbot-triage Bot requested review from alalazo and johnwparent July 14, 2026 17:52
johnwparent
johnwparent previously approved these changes Jul 14, 2026
@johnwparent
johnwparent enabled auto-merge (squash) July 14, 2026 17:57
@johnwparent

johnwparent commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

I haven't even announced 4.4.0 yet, you're quick 😄

@bernhardkaindl

Copy link
Copy Markdown
Contributor

jfyi, this has some pipeline CI failure, and 4.2.4 from #4290 could be moved here.

@spackbot-triage
spackbot-triage Bot requested a review from johnwparent July 15, 2026 06:24
@rbberger rbberger changed the title cmake: add v4.3.4 and v4.4.0 cmake: add 4.2.4, v4.3.4 and v4.4.0 Jul 15, 2026
@rbberger
rbberger disabled auto-merge July 15, 2026 06:26
@rbberger

Copy link
Copy Markdown
Member Author

Looks like hpctoolkit can't find the installed dyninst.

alalazo
alalazo previously approved these changes Jul 15, 2026
@alalazo alalazo self-assigned this Jul 15, 2026
@alecbcs alecbcs changed the title cmake: add 4.2.4, v4.3.4 and v4.4.0 cmake: add v4.2.4, v4.3.4, v4.4.0 Jul 16, 2026
@rbberger

rbberger commented Jul 18, 2026

Copy link
Copy Markdown
Member Author

@johnwparent I went down the rabbit hole. Seems like it's either a cmake regression, or bad CMake is now triggering "This should not happen" errors. The hpctoolkit meson.build also seems partly wrong/outdated. It should probably use cmake_package_version instead of version, and also not a range. It ends up becoming an VERSION <empty-string>, which leads to it being interpreted as component name. After fixing that I'm getting further to at least boost_system not found. More next week unless someone beats me to it.

Probably related: mesonbuild/meson#16007

@rbberger

Copy link
Copy Markdown
Member Author

@johnwparent there seems to be a regression with the find_package(Threads)/pthreads/pthread detection. Normally it should try pthreads, fail, and then find pthread. But the configure of the trycompile for pthreads doesn't even finish.

Put cmake in trace mode, but with variables expanded.
Put cmake in trace mode and sets the trace output format.
The --no-warn-unused-cli option is deprecated.  Use -Wno-unused-cli instead.
debug trycompile on
Put cmake in trace mode and redirect trace output to a file instead of stderr.
Trace will be written to cmake_trace.txt
CMake Debug Log at /home/rberger/GitHub/spack/opt/spack/linux-m1/cmake-4.4.0-g3p67dsqfjcoamokaurlacw24osnpkt7/share/cmake-4.4/Modules/CheckLibraryExists.cmake:154 (try_compile):
  Executing try_compile (CMAKE_HAVE_PTHREADS_CREATE) in:

    /tmp/rberger/spack-stage/spack-stage-hpctoolkit-2026.0.1-cs7bltyr4oept662bp6farn6g7mvsivz/spack-build-cs7blty/meson-private/cmake_Dyninst/CMakeFiles/CMakeScratch/TryCompile-OJjWGb
Call Stack (most recent call first):
  /home/rberger/GitHub/spack/opt/spack/linux-m1/cmake-4.4.0-g3p67dsqfjcoamokaurlacw24osnpkt7/share/cmake-4.4/Modules/FindThreads.cmake:175 (check_library_exists)
  /home/rberger/GitHub/spack/opt/spack/linux-m1/cmake-4.4.0-g3p67dsqfjcoamokaurlacw24osnpkt7/share/cmake-4.4/Modules/FindThreads.cmake:238 (_threads_check_lib)
  /home/rberger/GitHub/spack/opt/spack/linux-m1/cmake-4.4.0-g3p67dsqfjcoamokaurlacw24osnpkt7/share/cmake-4.4/Modules/CMakeFindDependencyMacro.cmake:93 (find_package)
  /home/rberger/GitHub/spack/opt/spack/linux-m1/cmake-4.4.0-g3p67dsqfjcoamokaurlacw24osnpkt7/share/cmake-4.4/Modules/CMakeFindDependencyMacro.cmake:125 (__find_dependency_common)
  /home/rberger/GitHub/spack/opt/spack/linux-m1/boost-1.90.0-k5ecdaa7e2intd4eb4kaqz5dpv2tjwat/lib/cmake/boost_thread-1.90.0/boost_thread-config.cmake:118 (find_dependency)
  /home/rberger/GitHub/spack/opt/spack/linux-m1/boost-1.90.0-k5ecdaa7e2intd4eb4kaqz5dpv2tjwat/lib/cmake/Boost-1.90.0/BoostConfig.cmake:141 (find_package)
  /home/rberger/GitHub/spack/opt/spack/linux-m1/boost-1.90.0-k5ecdaa7e2intd4eb4kaqz5dpv2tjwat/lib/cmake/Boost-1.90.0/BoostConfig.cmake:262 (boost_find_component)
  /home/rberger/GitHub/spack/opt/spack/linux-m1/dyninst-13.0.0-bjqosruwxbovf2u7zsduplljnxxhbar2/lib/cmake/Dyninst/tpls/DyninstBoost.cmake:39 (find_package)
  /home/rberger/GitHub/spack/opt/spack/linux-m1/dyninst-13.0.0-bjqosruwxbovf2u7zsduplljnxxhbar2/lib/cmake/Dyninst/DyninstConfig.cmake:6 (include)
  CMakeLists.txt:20 (find_package)


CMake Error: This should not have happened. If you see this message, you are probably using a broken CMakeLists.txt file or a problematic release of CMake

@rbberger

rbberger commented Jul 18, 2026

Copy link
Copy Markdown
Member Author

I've tracked this further down to the a toolchain file that is used by meson. It sets:

set(CMAKE_C_COMPILER_LOADED "1")

which now breaks. See my comment here: mesonbuild/meson#16007 (comment)

@rbberger

Copy link
Copy Markdown
Member Author

One temporary workaround for this should be falling back to CMake 4.3.4 for anything that uses Meson.

@johnwparent

Copy link
Copy Markdown
Contributor

@rbberger I added #5779 for 4.4.1, if you want to drop 4.4.0 here this should land

@rbberger rbberger changed the title cmake: add v4.2.4, v4.3.4, v4.4.0 cmake: add v4.2.4, v4.3.4 Jul 28, 2026
@spackbot-triage
spackbot-triage Bot requested a review from alalazo July 28, 2026 21:05
@rbberger

Copy link
Copy Markdown
Member Author

@johnwparent done, let's see if this works.

@johnwparent johnwparent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rbberger
rbberger merged commit cf6dd5a into spack:develop Jul 28, 2026
17 checks passed
@rbberger
rbberger deleted the updates/cmake branch July 28, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-version Modifications to packages' `depends_on()` directives update-package Modifications to packages in the repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants