ROCm: Add the Therock 7.13.0 release to all packages - #4964
ROCm: Add the Therock 7.13.0 release to all packages#4964renjithravindrankannath wants to merge 21 commits into
Conversation
spackbot-triage
Bot
added
new-version
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
1a11f71 to
63b7546
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/amdsmi/package.py
repos/spack_repo/builtin/packages/comgr/package.py
repos/spack_repo/builtin/packages/composable_kernel/package.py
repos/spack_repo/builtin/packages/grpc/package.py
repos/spack_repo/builtin/packages/hip/package.py
repos/spack_repo/builtin/packages/hip_tensor/package.py
repos/spack_repo/builtin/packages/hip_tests/package.py
repos/spack_repo/builtin/packages/hipblas/package.py
repos/spack_repo/builtin/packages/hipblas_common/package.py
repos/spack_repo/builtin/packages/hipblaslt/package.py
repos/spack_repo/builtin/packages/hipcc/package.py
repos/spack_repo/builtin/packages/hipcub/package.py
repos/spack_repo/builtin/packages/hipdnn/package.py
repos/spack_repo/builtin/packages/hipfft/package.py
repos/spack_repo/builtin/packages/hipify_clang/package.py
repos/spack_repo/builtin/packages/hiprand/package.py
repos/spack_repo/builtin/packages/hipsolver/package.py
repos/spack_repo/builtin/packages/hipsparse/package.py
repos/spack_repo/builtin/packages/hipsparselt/package.py
repos/spack_repo/builtin/packages/hsa_amd_aqlprofile/package.py
repos/spack_repo/builtin/packages/hsa_rocr_dev/package.py
repos/spack_repo/builtin/packages/llvm_amdgpu/package.py
repos/spack_repo/builtin/packages/migraphx/package.py
repos/spack_repo/builtin/packages/miopen_hip/package.py
repos/spack_repo/builtin/packages/mivisionx/package.py
repos/spack_repo/builtin/packages/py_barectf/package.py
repos/spack_repo/builtin/packages/rccl/package.py
repos/spack_repo/builtin/packages/rdc/package.py
repos/spack_repo/builtin/packages/rocblas/package.py
repos/spack_repo/builtin/packages/rocfft/package.py
repos/spack_repo/builtin/packages/rocm_cmake/package.py
repos/spack_repo/builtin/packages/rocm_core/package.py
repos/spack_repo/builtin/packages/rocm_dbgapi/package.py
repos/spack_repo/builtin/packages/rocm_debug_agent/package.py
repos/spack_repo/builtin/packages/rocm_device_libs/package.py
repos/spack_repo/builtin/packages/rocm_gdb/package.py
repos/spack_repo/builtin/packages/rocm_opencl/package.py
repos/spack_repo/builtin/packages/rocm_smi_lib/package.py
repos/spack_repo/builtin/packages/rocm_validation_suite/package.py
repos/spack_repo/builtin/packages/rocminfo/package.py
repos/spack_repo/builtin/packages/rocmlir/package.py
repos/spack_repo/builtin/packages/rocprim/package.py
repos/spack_repo/builtin/packages/rocprofiler_compute/package.py
repos/spack_repo/builtin/packages/rocprofiler_dev/package.py
repos/spack_repo/builtin/packages/rocprofiler_register/package.py
repos/spack_repo/builtin/packages/rocprofiler_sdk/package.py
repos/spack_repo/builtin/packages/rocprofiler_systems/package.py
repos/spack_repo/builtin/packages/rocrand/package.py
repos/spack_repo/builtin/packages/rocshmem/package.py
repos/spack_repo/builtin/packages/rocsolver/package.py
repos/spack_repo/builtin/packages/rocsparse/package.py
repos/spack_repo/builtin/packages/rocthrust/package.py
repos/spack_repo/builtin/packages/roctracer_dev/package.py
repos/spack_repo/builtin/packages/roctracer_dev_api/package.py
repos/spack_repo/builtin/packages/rocwmma/package.py
repos/spack_repo/builtin/packages/rpp/package.py
�[1;34m==> �[0mrunning ruff format
1 file reformatted, 55 files left unchanged
�[1;34m==> �[0mrunning ruff check
All checks passed!
�[1;34m==> �[0mstyle checks passed
I've updated the branch with style fixes. |
renjithravindrankannath
changed the title
|
@spackbot rerun pipeline |
|
I've started that pipeline for you! |
|
@spackbot rerun pipeline |
|
I've started that pipeline for you! |
|
@spackbot fix style |
|
umpire@2023.06.0 was building using hip@7.0.2 and was accessing a member ,_memoryType' inside 'hipPointerAttribute_t' that i believe is deprecated a while ago. It should instead access Type inside 'hipPointerAttribute_t'. |
|
extending the patch patch("camp-rocm6.patch", when="@2023.06.0: +rocm ^hip@6:") inside camp package will fix the umpire build error. |
|
Hi @scheibelp, |
There was a problem hiding this comment.
@renjithravindrankannath, the tarball and sha of rocmlir@7.13 should be the same as for @7.2.3?
There was a problem hiding this comment.
There is no 7.13 tag for rocmlir. rocm-7.2.3 tag of rocmlir is compatible with therock-7.13.
There was a problem hiding this comment.
Ack, this is like hipfort, rocal, and rocjpeg which also got no version("7.13.0").
However rocmlir was updated to re-release "7.2.3" as "7.13.0" as 2nd time (same source), which does not look right, and is not what those other packages do.
+ "7.13.0",
+ url="https://github.com/ROCm/rocMLIR/archive/refs/tags/rocm-7.2.3.tar.gz",
+ sha256="415eacd1fbd916e2f62cd7b8acad0bf8b66cdac0211ebce09eca931843c2dce2",
+ )
version(
"7.2.3",
url="https://github.com/ROCm/rocMLIR/archive/refs/tags/rocm-7.2.3.tar.gz",
sha256="415eacd1fbd916e2f62cd7b8acad0bf8b66cdac0211ebce09eca931843c2dce2",Those tarballs are the same, so it should just be used for 7.2.3 (as you said, there is no rocMLIR 7.13.0)
I assume there is just a misunderstanding, so I'll add suggestion to explain what I meant.
There was a problem hiding this comment.
Removed 7.13 from rocmlir as suggested.
|
Besides the question I raised and the three minor suggestions, I'd also like to check with Copilot's review if it finds something not noted so far. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Spack ROCm/TheRock package set to support the therock-7.13.0 release, including aligning version metadata, migrating many packages to a centralized rocm_url_map-driven URL selection mechanism, and adding/refreshing patches and build adjustments needed for the new TheRock super-repo layout.
Changes:
- Introduces
ROCmLibrary.url_for_version()with per-packagerocm_url_mapto replace many bespokeurl_for_version()implementations. - Adds
7.13.0versions across a large set of ROCm packages and adjusts dependencies/build layout for TheRock/rocm-systems + rocm-libraries tag schemes. - Adds new patches and conditional build flags (e.g., rocWMMA OpenMP linkage workaround, ROCmValidationSuite 7.13 fixes, device-libs path fixes).
Reviewed changes
Copilot reviewed 72 out of 72 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| repos/spack_repo/builtin/build_systems/rocm.py | Adds ROCmLibrary.url_for_version() driven by rocm_url_map. |
| repos/spack_repo/builtin/packages/transferbench/package.py | Adds rocm_url_map for centralized URL generation. |
| repos/spack_repo/builtin/packages/rpp/package.py | Adds 7.13.0 version and updates dependency condition list. |
| repos/spack_repo/builtin/packages/rocwmma/package.py | Converts to ROCmLibrary + rocm_url_map, adds 7.13.0, patch, and benchmark toggle logic. |
| repos/spack_repo/builtin/packages/rocwmma/0003-Fix-libopenmp.so-and-libamdhip64.so-not-found-error-7.13.patch | Adds 7.13-specific CMake linkage workaround for OpenMP/HIP libs. |
| repos/spack_repo/builtin/packages/roctracer_dev/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0. |
| repos/spack_repo/builtin/packages/roctracer_dev_api/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0. |
| repos/spack_repo/builtin/packages/rocthrust/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0. |
| repos/spack_repo/builtin/packages/rocsparse/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0 and deps. |
| repos/spack_repo/builtin/packages/rocsolver/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0 and deps. |
| repos/spack_repo/builtin/packages/rocshmem/package.py | Adds rocm_url_map, 7.13.0, deps, and TheRock root CMakeLists path handling. |
| repos/spack_repo/builtin/packages/rocrand/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0 and deps. |
| repos/spack_repo/builtin/packages/rocprofiler_systems/package.py | Converts to ROCmLibrary, adds rocm_url_map, adds 7.13.0 git tag + submodules, and variant default changes by version. |
| repos/spack_repo/builtin/packages/rocprofiler_sdk/package.py | Converts to ROCmLibrary, adds rocm_url_map, adds 7.13.0 git tag + submodules, and dependency list updates. |
| repos/spack_repo/builtin/packages/rocprofiler_register/package.py | Replaces url_for_version() with rocm_url_map and adds 7.13.0. |
| repos/spack_repo/builtin/packages/rocprofiler_dev/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0/deps. |
| repos/spack_repo/builtin/packages/rocprofiler_compute/package.py | Adds rocm_url_map, 7.13.0, updates Python deps, adds LLVM/HIP deps by version, adds env setup and vendored-dir workaround. |
| repos/spack_repo/builtin/packages/rocprofiler_compute_viewer/package.py | Converts to ROCmLibrary and replaces url_for_version() with rocm_url_map. |
| repos/spack_repo/builtin/packages/rocprim/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0/deps. |
| repos/spack_repo/builtin/packages/rocmlir/package.py | Adds a 7.13.0 version entry (currently pointing at 7.2.3 tarball). |
| repos/spack_repo/builtin/packages/rocminfo/package.py | Replaces url_for_version() with rocm_url_map and adds 7.13.0/deps. |
| repos/spack_repo/builtin/packages/rocm_validation_suite/package.py | Adds 7.13.0 source, new amdgpu_target variant, adds 7.13 patches and deps, and adjusts patch ranges. |
| repos/spack_repo/builtin/packages/rocm_validation_suite/011_add_inc_and_lib_path_for_pciutils-7.13.patch | Adds pciutils include/lib discovery adjustments for 7.13. |
| repos/spack_repo/builtin/packages/rocm_validation_suite/013-add-hiprand-includes-7.13.patch | Adds numactl discovery and fixes includes for hiprand/rocrand and pkg-config usage. |
| repos/spack_repo/builtin/packages/rocm_smi_lib/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0/deps. |
| repos/spack_repo/builtin/packages/rocm_opencl/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0/deps. |
| repos/spack_repo/builtin/packages/rocm_gdb/package.py | Adds rocm_url_map and 7.13.0 version/deps. |
| repos/spack_repo/builtin/packages/rocm_examples/package.py | Adds 7.13.0 and disables some examples/features for 7.13 due to upstream issues. |
| repos/spack_repo/builtin/packages/rocm_device_libs/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0. |
| repos/spack_repo/builtin/packages/rocm_debug_agent/package.py | Adds rocm_url_map, 7.13.0, root CMakeLists path handling, and 7.13-specific patch selection. |
| repos/spack_repo/builtin/packages/rocm_debug_agent/0001-Drop-overly-strict-Werror-flag-7.13.patch | Drops -Werror for 7.13 layout. |
| repos/spack_repo/builtin/packages/rocm_dbgapi/package.py | Adds rocm_url_map, 7.13.0, root CMakeLists path handling, and adjusts patch paths for 7.13 layout. |
| repos/spack_repo/builtin/packages/rocm_core/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0/deps. |
| repos/spack_repo/builtin/packages/rocm_cmake/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0/deps. |
| repos/spack_repo/builtin/packages/rocm_bandwidth_test/package.py | Adds rocm_url_map for URL generation. |
| repos/spack_repo/builtin/packages/rocjpeg/package.py | Adds rocm_url_map. |
| repos/spack_repo/builtin/packages/rocfft/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0/deps. |
| repos/spack_repo/builtin/packages/rocdecode/package.py | Adds rocm_url_map, 7.13.0, deps, and root CMakeLists path handling for TheRock layout. |
| repos/spack_repo/builtin/packages/rocblas/package.py | Converts to ROCmLibrary + rocm_url_map, adds 7.13.0, and tightens patch range. |
| repos/spack_repo/builtin/packages/rocal/package.py | Adds rocm_url_map. |
| repos/spack_repo/builtin/packages/rdc/package.py | Adds 7.13.0 and updates url_for_version() for TheRock tag scheme. |
| repos/spack_repo/builtin/packages/rccl/package.py | Adds 7.13.0 and updates url_for_version() for TheRock tag scheme. |
| repos/spack_repo/builtin/packages/py_barectf/package.py | Adds patch application for pkg-resources compatibility. |
| repos/spack_repo/builtin/packages/py_barectf/fix-pkg-resources.patch | Switches from pkg_resources to importlib.resources fallback logic. |
| repos/spack_repo/builtin/packages/mivisionx/package.py | Adds rocm_url_map, 7.13.0 branch version, and updates rpp dependency to match amdgpu_target. |
| repos/spack_repo/builtin/packages/miopen_hip/package.py | Converts to ROCmLibrary + rocm_url_map, adds 7.13.0, expands rocmlir dep list, and disables MLIR for 7.13. |
| repos/spack_repo/builtin/packages/migraphx/package.py | Adds rocm_url_map, 7.13.0 branch version, patch range tweak, expands deps, and disables MLIR for 7.13. |
| repos/spack_repo/builtin/packages/llvm_amdgpu/package.py | Adds 7.13.0 URL logic, provides LLVM 23 for 7.13, adds resources and updates device-libs bitcode path for LLVM version. |
| repos/spack_repo/builtin/packages/hsa_rocr_dev/rocm-device-lib-path.patch | Adds --rocm-device-lib-path to clang invocations when BITCODE_DIR is set. |
| repos/spack_repo/builtin/packages/hsa_rocr_dev/package.py | Converts to ROCmLibrary + rocm_url_map, adds 7.13.0, and applies device-lib-path patch for 7.13. |
| repos/spack_repo/builtin/packages/hsa_amd_aqlprofile/package.py | Adds 7.13.0 and updates url_for_version() for TheRock tags; updates dependency list. |
| repos/spack_repo/builtin/packages/hipsparselt/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0/deps. |
| repos/spack_repo/builtin/packages/hipsparse/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0/deps. |
| repos/spack_repo/builtin/packages/hipsolver/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0/deps. |
| repos/spack_repo/builtin/packages/hiprand/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0/deps. |
| repos/spack_repo/builtin/packages/hipify_clang/package.py | Adds rocm_url_map, 7.13.0, and dependency list updates. |
| repos/spack_repo/builtin/packages/hipfort/package.py | Adds rocm_url_map. |
| repos/spack_repo/builtin/packages/hipfft/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0/deps. |
| repos/spack_repo/builtin/packages/hipdnn/package.py | Converts to ROCmLibrary + rocm_url_map, adds 7.13.0, and disables clang-tidy for 7.13. |
| repos/spack_repo/builtin/packages/hipcub/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0/deps. |
| repos/spack_repo/builtin/packages/hipcc/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0. |
| repos/spack_repo/builtin/packages/hipblaslt/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0/deps. |
| repos/spack_repo/builtin/packages/hipblas/package.py | Converts to ROCmLibrary + rocm_url_map and adds 7.13.0/deps. |
| repos/spack_repo/builtin/packages/hipblas_common/package.py | Converts to ROCmLibrary + rocm_url_map, adds 7.13.0, and reorders version declarations. |
| repos/spack_repo/builtin/packages/hip/package.py | Converts to ROCmLibrary + rocm_url_map, adds 7.13.0, adds rocm-systems resource for 7.13, and adjusts layout paths for 7.13. |
| repos/spack_repo/builtin/packages/hip_tests/package.py | Converts to ROCmLibrary + rocm_url_map, adds 7.13.0, adds build dep for pyyaml, and tightens patch range. |
| repos/spack_repo/builtin/packages/hip_tensor/package.py | Converts to ROCmLibrary + rocm_url_map, adds 7.13.0, and minor docstring normalization. |
| repos/spack_repo/builtin/packages/grpc/package.py | Updates patch logic for glob.cc path change in grpc 1.67+. |
| repos/spack_repo/builtin/packages/composable_kernel/package.py | Adds 7.13.0 and updates url_for_version() for TheRock tags. |
| repos/spack_repo/builtin/packages/comgr/package.py | Adds 7.13.0 and updates url_for_version() for TheRock tags and deps. |
| repos/spack_repo/builtin/packages/camp/package.py | Broadens rocm6 patch applicability range. |
| repos/spack_repo/builtin/packages/amdsmi/package.py | Adds 7.13.0 and updates url_for_version() plus libdrm dependency constraints for 7.13. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| version( | ||
| "7.13.0", | ||
| url="https://github.com/ROCm/rocMLIR/archive/refs/tags/rocm-7.2.3.tar.gz", | ||
| sha256="415eacd1fbd916e2f62cd7b8acad0bf8b66cdac0211ebce09eca931843c2dce2", | ||
| ) |
There was a problem hiding this comment.
Removed 7.13 in rocmlir as suggested.
| rocm_url_map = [ | ||
| ("7.1.1", "https://github.com/ROCm/hipBLASLt/archive/refs/tags/rocm-{0}.tar.gz"), | ||
| ("7.2.3", "https://github.com/ROCm/rocm-libraries/archive/rocm-{0}.tar.gz"), | ||
| (None, "https://github.com/ROCm/rocm-libraries/archive/refs/tags/therock-{1}.{2}.tar.gz"), | ||
| ] |
There was a problem hiding this comment.
If the download of 7.1.1 is still working I think that would not be a problem.
But hipblaslt@7.1.1 currently can'be concretized (not with develop either)
spack fetch hipblaslt@7.1.1
==> Error: failed to concretize `hipblaslt@7.1.1` for the following reasons:
1. spdlog: '^fmt@11.1:' conflicts with '@:1.12'
2. spdlog: '^fmt@11.1:' conflicts with '@:1.12'
required because conflict constraint @:1.12
required because hipblaslt depends on spdlog@:1.14 when @7.1:
required because hipblaslt@7.1.1 requested explicitly
required because conflict is triggered when ^fmt@11.1:
required because spdlog depends on fmt@5.3:
required because hipblaslt depends on spdlog@:1.14 when @7.1:
required because hipblaslt@7.1.1 requested explicitly
required because spdlog depends on fmt@7: when @1.7:
required because spdlog depends on fmt@8: when @1.9:
required because rocprofiler-register depends on fmt@:12.1 when @:7
required because hsa-rocr-dev depends on rocprofiler-register@7.1.1 when @7.1.1
required because roctracer-dev depends on hsa-rocr-dev@7.1.1 when @7.1.1
required because hipblaslt depends on roctracer-dev@7.1.1 when @7.1.1
required because rocminfo depends on hsa-rocr-dev@7.1.1 when @7.1.1
required because roctracer-dev depends on rocminfo@7.1.1 when @7.1.1
required because hip depends on rocminfo@7.1.1 when @7.1.1+rocm
required because roctracer-dev depends on hip@7.1.1+rocm when @7.1.1
required because hipblaslt depends on hip@7.1.1 when @7.1.1
required because hip depends on hsa-rocr-dev@7.1.1 when @7.1.1+rocm
required because hip depends on rocprofiler-register@7.1.1 when @7.1.1
required because hipblaslt depends on fmt@11.1: when @7.0:
required because hipblaslt depends on spdlog@:1.14 when @7.1:Suggested fix: #5743
|
Hi @renjithravindrankannath it looks like @bernhardkaindl found
The other comments in his review look like they can be done later, so I think that's the last thing (it LGTM) |
|
Hi @renjithravindrankannath, thanks for working on the review feedback! While there are still review comments being addressed, I don't think there's much benefit in running the full GitLab CI pipeline for every small fixup commit. It will likely be more efficient to wait until the review feedback has been addressed before triggering a full CI run. Sorry that we don't currently have a label or query to defer the full GitLab CI pipeline until all review comments have been resolved. At the moment, the only mechanism we have is whether the PR is marked as a draft, which controls the pipeline behaviour. Because of that, I'd suggest keeping the PR as a draft while you're working through the review feedback, and only marking it as Ready for review when you'd like the full GitLab CI pipeline to run again. This is just a suggestion from me personally, and an idea is to just prefer allocating CI resources where they are most useful at this moment, and only temporary - and also to indicate that review feedback is currently being incorporated. It isn't intended to change the perception of the PR or the quality of the work in any way, and it certainly shouldn't influence anyone following or reviewing the PR. It's simply a convenient way for us to avoid unnecessary CI runs while the review comments are being addressed. When you need to trigger a full CI run after a particular push, you can simply mark the PR as Ready for review around the time you push that change. That will clear the draft status and allow the full GitLab CI pipeline to run. |
Co-authored-by: Afzal Patel <122491982+afzpatel@users.noreply.github.com>
There was a problem hiding this comment.
Just in case my suggestion is not shown below, this change request refers to this suggestion:
https://github.com/spack/spack-packages/pull/4964/changes#r3662006872
| version( | ||
| "7.13.0", | ||
| url="https://github.com/ROCm/rocMLIR/archive/refs/tags/rocm-7.2.3.tar.gz", | ||
| sha256="415eacd1fbd916e2f62cd7b8acad0bf8b66cdac0211ebce09eca931843c2dce2", | ||
| ) |
There was a problem hiding this comment.
@renjithravindrankannath, follow-up from #4964 (comment):
As you said, rocMLIR has no 7.13 release, so it should not be added as a copy of 7.2.3:
7.13.0 is defined with the exact same tarball URL (rocm-7.2.3.tar.gz) and sha256 as 7.2.3, which makes the version metadata inconsistent and likely incorrect for a 7.13.0 bump.
To not duplicate 7.2.3 as 7.13, remove those added lines again:
| version( | |
| "7.13.0", | |
| url="https://github.com/ROCm/rocMLIR/archive/refs/tags/rocm-7.2.3.tar.gz", | |
| sha256="415eacd1fbd916e2f62cd7b8acad0bf8b66cdac0211ebce09eca931843c2dce2", | |
| ) |
This should be fine because using git grep -B2 rocmlir, I also found no dependency on rocmlir@7.13 therefore does not need to be created (like the current PR diff would do):
repos/spack_repo/builtin/packages/migraphx/package.py-
repos/spack_repo/builtin/packages/migraphx/package.py- for ver in ["6.0.0", "6.0.2", "6.1.0", "6.1.1", "6.1.2", "6.2.0", "6.2.1", "6.2.4"]:
repos/spack_repo/builtin/packages/migraphx/package.py: depends_on(f"rocmlir@{ver}", when=f"@{ver}")
--
repos/spack_repo/builtin/packages/migraphx/package.py- "7.2.3",
repos/spack_repo/builtin/packages/migraphx/package.py- ]:
repos/spack_repo/builtin/packages/migraphx/package.py: depends_on(f"rocmlir@{ver}", when=f"@{ver}")
--
repos/spack_repo/builtin/packages/miopen_hip/package.py- "7.2.3",
repos/spack_repo/builtin/packages/miopen_hip/package.py- ]:
repos/spack_repo/builtin/packages/miopen_hip/package.py: depends_on(f"rocmlir@{ver}", when=f"@{ver}")There was a problem hiding this comment.
Updated rocmlir and other packages depending rocmlir.
|
@renjithravindrankannath, AFAICS, the commit of reverting adding a rocmlir@7.13 version with source of rocm-7.2.3 hasn't been pushed yet: Can you push the commmit to revert change? |
|
With the new updates, Concretizing hipblaslt@7.1 and hipblaslt@7.2 is still not possible: #4964 (comment) $ git log -1 --oneline
f3231652f2 (HEAD -> therock) Removing tuple expression
$ spack spec hipblaslt@7.1.1
==> Error: failed to concretize `hipblaslt@7.1.1` for the following reasons:
1. spdlog: '^fmt@11.1:' conflicts with '@:1.12'
2. spdlog: '^fmt@11.1:' conflicts with '@:1.12'
required because conflict constraint @:1.12
required because hipblaslt depends on spdlog@:1.14 when @7.1:7.2
required because hipblaslt@7.1.1 requested explicitly
required because conflict is triggered when ^fmt@11.1:
required because spdlog depends on fmt@5.3:
required because hipblaslt depends on spdlog@:1.14 when @7.1:7.2
required because hipblaslt@7.1.1 requested explicitly
required because spdlog depends on fmt@7: when @1.7:
required because spdlog depends on fmt@8: when @1.9:
required because rocprofiler-register depends on fmt@:12.1 when @:7
required because hsa-rocr-dev depends on rocprofiler-register@7.1.1 when @7.1.1
required because roctracer-dev depends on hsa-rocr-dev@7.1.1 when @7.1.1
required because hipblaslt depends on roctracer-dev@7.1.1 when @7.1.1
required because rocminfo depends on hsa-rocr-dev@7.1.1 when @7.1.1
required because roctracer-dev depends on rocminfo@7.1.1 when @7.1.1
required because hip depends on rocminfo@7.1.1 when @7.1.1+rocm
required because roctracer-dev depends on hip@7.1.1+rocm when @7.1.1
required because hipblaslt depends on hip@7.1.1 when @7.1.1
required because hip depends on hsa-rocr-dev@7.1.1 when @7.1.1+rocm
required because hip depends on rocprofiler-register@7.1.1 when @7.1.1
required because hipblaslt depends on fmt@11.1: when @7.0:
required because hipblaslt depends on spdlog@:1.14 when @7.1:7.2I know this wasn't caused by this PR, but I wanted to remind that this issue wasn't solved. |
7.2.x which need the old spdlog/fmt pair, while allowing: - Versions 7.0.0 and 7.0.2 to use fmt@11.1+ - Versions 7.13.0+ to use fmt@11.1+ - Versions 7.1.x and 7.2.x to use the compatible old fmt version with spdlog@:1.14
Thanks for pointing that. Updated the dependency to exclude versions 7.1.x and 7.2.x which need the old spdlog/fmt pair, while allowing:
|
rocmlir file change was missed in the earlier commit. Just pushed the same. Thanks. |
Therock 7.13.0 Release
This PR updates Spack packages for the Therock 7.13.0 release, AMD's lightweight open-source build platform for HIP and ROCm.
About TheRock
TheRock is a CMake super-project that enables source-based builds of HIP (Heterogeneous-compute Interface for Portability) and ROCm (Radeon Open Compute), AMD's open-source GPU computing platform. It serves as the integration point for ROCm components, providing:
TheRock 7.13 integrates components from two major ROCm super-repositories:
Packages Updated in This PR
ROCm Systems Components (from https://github.com/ROCm/rocm-systems)
Core Runtime & Management
HIP & Common Language Runtime (CLR)
HSA Runtime & Debug Infrastructure
Profiling & Tracing Tools
Media & Communication Libraries
LLVM Compiler & Device Libraries
ROCm Libraries Components (from https://github.com/ROCm/rocm-libraries)
HIP Math Libraries
HIP Parallel Primitives & Utilities
ROCm Native Math Libraries
Deep Learning & Neural Network Libraries
Additional ROCm Ecosystem Packages
These packages are part of the broader ROCm ecosystem but are maintained separately from the rocm-systems and rocm-libraries super-repositories:
AI/ML Frameworks & Optimization
Communication Libraries
Performance & Validation Tools
Development & Build Support
Language Bindings
Build Dependencies
Key Changes in This Release
1. Version Bump
2. LLVM Toolchain Update
3. Build System Improvements
url_for_version()methods--rocm-device-lib-pathflag to clang commands to resolve device library discovery issues4. Patches & Fixes
ROCWMMA_BUILD_BENCHMARK_TESTS=OFF) for 7.13+ (to be enabled later)ROCM_EXAMPLES_ENABLE_ROCDECODE=OFF) for 7.13+ due to upstream path issues5. Code Quality
ROCm Packages NOT Updated to 7.13 in This PR
The following ROCm packages are included in TheRock but remain at version 7.2.3 and are not updated to 7.13.0 in this PR:
These packages are part of TheRock but are maintained separately and follow their own release schedule. While they are integrated into TheRock 7.13, their package versions remain at 7.2.3 rather than being bumped to match the 7.13.0 release version.
Package Statistics
Testing & Validation
TheRock's build system enables comprehensive multi-component testing:
Related Links