fix: fallback to client hash when BlockHash is missing - #215
Merged
Conversation
1.70.0Bug Fixes
Features
|
JayWhite2357
force-pushed
the
fix/hash-fallback
branch
from
August 5, 2026 14:55
8ee5efa to
95794da
Compare
tlovell-sxt
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The runtime prunes the block number to block hash mappings. As a result, the
prover_db_indexercan fail to get the events needed. See theblock_hash_falls_back_to_client_once_frame_system_prunes_the_entrytest in this PR for an example.What changes are included in this PR?
client::hashis added to get the block hash from the client.block_hashhelper method is added and used that falls back to getting the block hash from the client instead of the state.Are these changes tested?
Yes