Skip to content

refactor: use idiomatic snafu in prover_db_indexer - #213

Merged
JayWhite2357 merged 1 commit into
mainfrom
feat/lib-snafu-idiomatic
Aug 3, 2026
Merged

refactor: use idiomatic snafu in prover_db_indexer#213
JayWhite2357 merged 1 commit into
mainfrom
feat/lib-snafu-idiomatic

Conversation

@JayWhite2357

@JayWhite2357 JayWhite2357 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

We should use snafu in the manner it was intended.

What changes are included in this PR?

  • context is used instead of map_err
  • fields of the error varients are named source rather than error

Are these changes tested?

This is a pure refactoring PR.

@JayWhite2357
JayWhite2357 requested review from a team as code owners July 31, 2026 00:03
@github-actions

Copy link
Copy Markdown

1.70.0

Bug Fixes

  • make on chain indexer keys saturate rather than default to (5f794de
  • use finalized block in prover-db-indexer (50438ab

Features

  • add helper that queries the client for s. (4fc3952
  • add client native interface and extenality (d9c6c4d
  • add generic config key-value store for offchain workers (117b845
  • Document Snapshot Download Process (4c2608b
  • register client externality to offchain worker (338c213
  • use generic key value config for prover_db_indexing instead of storage/CLI based config (faff564

@JayWhite2357 JayWhite2357 changed the title refactor: use idiomatic snafu context/ensure in prover_db_indexer refactor: use idiomatic snafu in prover_db_indexer Aug 3, 2026

@tlovell-sxt tlovell-sxt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not against this. If we ever transition back to thiserror I suppose keeping map_err would be a slightly smaller diff? maybe? not a big deal

@JayWhite2357

Copy link
Copy Markdown
Contributor Author

Not against this. If we ever transition back to thiserror I suppose keeping map_err would be a slightly smaller diff? maybe? not a big deal

I've thought about that. But, I don't know if we'll do that any time soon.

@JayWhite2357
JayWhite2357 force-pushed the feat/lib-snafu-idiomatic branch from 44250d0 to 370db18 Compare August 3, 2026 18:36
@JayWhite2357
JayWhite2357 force-pushed the feat/lib-snafu-idiomatic branch from 370db18 to eaf3141 Compare August 3, 2026 18:38
@JayWhite2357
JayWhite2357 enabled auto-merge August 3, 2026 18:38
@JayWhite2357
JayWhite2357 merged commit 1a3fba7 into main Aug 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants