Skip to content

refactor: move sxt-chain-runtime to its own crate #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iajoiner wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: move sxt-chain-runtime to its own crate #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
060dcd7
refactor: move `sxt-chain-runtime` to its own crate
iajoiner Dec 2, 2025
7aa30f2
fix: disable clippy and other checks for generated code
iajoiner Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ members = [
"proof-of-sql/commitment-map",
"runtime",
"sxt-core",
"sxt-chain-runtime",
"proof-of-sql/on-chain-table",
"proof-of-sql/commitment-sql",
"proof-of-sql/static-setups",
Expand Down Expand Up @@ -72,6 +73,7 @@ pallet-system-tables = { path = "pallets/system_tables", default-features = fals
pallet-zkpay = { path = "pallets/zkpay", default-features = false }
pallet-smartcontracts = { path = "pallets/smartcontracts", default-features = false}
sxt-core = { path = "sxt-core", default-features = false }
sxt-chain-runtime = { path = "sxt-chain-runtime" }
pallet-tables = { path = "pallets/tables", default-features = false }
pallet-indexing = { path = "pallets/indexing", default-features = false }
native = { path = "native", default-features = false }
Expand Down
18 changes: 18 additions & 0 deletions sxt-chain-runtime/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
[package]
name = "sxt-chain-runtime"
version = "0.1.0"
license.workspace = true
authors.workspace = true
homepage.workspace = true
repository.workspace = true
edition.workspace = true

[dependencies]
subxt = { workspace = true }

[lints]
workspace = true

[lib]
doc = false
doctest = false
10 changes: 8 additions & 2 deletions sxt-core/src/sxt_chain_runtime.rs → sxt-chain-runtime/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
#[allow(dead_code, unused_imports, non_camel_case_types, unreachable_patterns)]
#[allow(clippy::all)]
#![allow(clippy::all)]
#![allow(
dead_code,
missing_docs,
unused_imports,
non_camel_case_types,
unreachable_patterns
)]
Comment thread
iajoiner marked this conversation as resolved.
#[allow(rustdoc::broken_intra_doc_links)]
pub mod api {
#[allow(unused_imports)]
Expand Down
2 changes: 2 additions & 0 deletions sxt-core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ tokio = { workspace = true, optional = true }
sc-client-api = { workspace = true, default-features = false, optional = true }
sp-blockchain = { workspace = true, default-features = false, optional = true }
sp-api = { workspace = true, default-features = false, optional = true}
sxt-chain-runtime = { workspace = true, optional = true }
proof-of-sql = { workspace = true, default-features = false }
exponential-backoff = { workspace = true, default-features = false, optional = true }
k256 = { workspace = true, default-features = false }
Expand Down Expand Up @@ -68,6 +69,7 @@ std = [
"dep:sc-client-api",
"dep:sp-blockchain",
"dep:exponential-backoff",
"dep:sxt-chain-runtime",
]
proptest = ["std", "dep:proptest", "on-chain-table/proptest"]

Expand Down
2 changes: 1 addition & 1 deletion sxt-core/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ pub mod attestation;
/// Autogenerated code used by Subxt to interact with the network as a client
#[cfg(all(feature = "std", not(doctest)))]
#[allow(missing_docs)]
Comment thread
iajoiner marked this conversation as resolved.
pub mod sxt_chain_runtime;
pub use sxt_chain_runtime;

@tlovell-sxt tlovell-sxt Dec 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it prohibitively difficult it to just remove this from sxt-core entirely? I imagine a few downstream services (event-forwarder, watcher, maybe canaries) will need to change their imports slightly

@iajoiner iajoiner Dec 4, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be hard at all

/// The maximum length of Identifiers
pub const IDENT_LENGTH: u32 = 64;

Expand Down
Loading