Conversation
Simplified event type creation Made skipUpdate a protected method on SourceBase Reduction actually uses the initialValue
Better naming Throwing for loose Reductions Unowned objects disposed at end of transition
Moving some things around to get around circular module dependencies Every ISource is Disposable Removed SourceObserverBase Effect correctly detects it's stale even when detached Fixed events firing a reference to the inner function instead of the proper event function Legacy @State decorator is bound to correct instance Model prototype factories inherited from base prototype Added createModel function for top-level model Graph nodes in state properties are tracked
SourceBase checks if value is allowed as state Events are not allowed as state
Reworked event scoping Using new BoundSource instead of Derivation for map/filter/filterMap
Setting displayName for model properties Added extendReduce for extending super class reductions Derivations run once when subscribed to collect sources Added createModel helper for creating loose model objects Caching getter sources during construction to avoid creating multiple sources Properly cleaning up sources overridden in sub models Moved Reduction's setValue out of its source tracking scope so child nodes can access it without throwing
Add paths to logs and generally cleaning them up
Implemented testing helpers Exposed detach on Derivation Exposed setValue on SourceBase RenderEffect attaches immediately useReactive uses trigger info as external state
Removed setState feature Model toJSON picks up properties from base classes StateProperty toJSON returns state of value
Properties register themselves with the model when accessed Only the outer-most @model constructor initializes properties
…lper properties are maintained
…clic dependencies
…disposable allocation
Fast-track for invalidatingSource Looping for early exit and avoiding array allocations
Fast-tracks for scalar <-> graph node changes Removing redundant checks
Fixing LegacyState test
Removing remaining semicolons Re-enabling commented-out tests React tests clean up rendered output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.