Skip to content

Redesign pass: profiles, home, phone tables; merge akanora's PRs #24–#29 - #20

Merged
github-actions[bot] merged 19 commits into
sourcejump:u/zasbufrom
zasbu:feat/mobile-profile-polish
Nov 8, 2026
Merged

github-actions[bot] merged 19 commits into
sourcejump:u/zasbufrom
zasbu:feat/mobile-profile-polish

Conversation

@zasbu

@zasbu zasbu commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Web redesign changes, plus akanora's six PRs from sourcejump/sourcejump merged with his authorship.

Web

  • Geist site-wide; Exo 2 bold for server names (font-server).
  • Profiles: the rank leads the header (one line under the name on phones) and follows the Style/Track menus; the picture is captioned as the latest world record or personal best; personal bests open best place first; no permanent WR row highlight.
  • Home: latest world records lead with the player; the records and top players panels end level.
  • Leaderboards on phones end the first view at the ranked number, the rest scrolls; the pager never moves when turning pages.
  • A board's first record shows (NEW); style menus list Autosync after Normal (display order only).

akanora's PRs

The preview reads beta's API, so the API changes (#24, #26, #28) aren't live there until the API is deployed. docs/plans/web-redesign-api.md lists what the lead needs to do.

just check passes: Rust tests (303), web tests (113), browser tests (5).

akanora and others added 19 commits November 8, 2026 15:07
tokio's Unix signals don't exist on other systems, so the API didn't compile
on Windows at all, which kept contributors there from running its tests or
the API itself. On Unix nothing changes: systemd still stops it with SIGTERM
and in-flight requests finish. Elsewhere it stops with Ctrl+C.
Every query that needed a track's current tier repeated "newest assignment
first, take one" against map_tiers, in 14 places across 8 files. The
current_map_tiers view (migration 0052) says it once. Conditions on map_id
and track still reach the primary key through it, so a single lookup reads
the same index rows as before. Behavior is unchanged; whether tiers are in
force (the tiers policy) is still each caller's call.
…ourcejump#26 branched

players/personal_bests.rs and the recent-runs count gained their own copies of
"newest assignment first, take one" after akanora's branch point, so sourcejump#26 could
not see them. Same lookup, same tiers-policy gate in the join condition.

Co-Authored-By: Claude <noreply@anthropic.com>
A server skips submitting runs that aren't faster than the player's
SourceJump PB (docs/domain.md), but reading those meant one leaderboard
request per player, style and track on every map change.
GET /v1/maps/{map}/personal-bests?players= takes up to 64 SteamID64s and
answers every style and track at once, with each best's rank, under the
same ETag as the map's records.

docs/api.md drops three sentences that repeat other docs, to stay within
its size budget.
A session lasts 30 days from its last use, and signing out ended only the
browser it came from, so a session left on someone else's computer stayed
signed in with no way to end it. POST /v1/auth/sign-out-everywhere ends
every session of the signed-in player and clears this browser's cookie;
like sign-out, it needs our Origin, and without a live session it only
clears the cookie. The account menu has "Sign out everywhere" under
"Sign out", as a plain form post like it.

docs/site-api.md drops where the auth endpoints are served from (Caddy or
Next.js), which docs/deploy.md has, to stay within its size budget.
sourcejump#28 answered a request with no session the same as a successful one: a
redirect back. A player whose session had just ended would be told their other
browsers were signed out when nothing was deleted. Sessions fail closed, so it
now answers 401 after the same Origin check as sign-out, and ends nothing.
Plain sign-out keeps clearing the cookie without a session; it has nothing to
promise about other browsers.

Co-Authored-By: Claude <noreply@anthropic.com>
Its only reader is a game server deciding which runs to submit, and that
server holds a key anyway; requiring one keeps a 64-player bulk lookup to
servers we know and costs the plugin nothing. A missing, unknown or revoked key
gets 401 before the query is read. The player list is now bounded while it is
parsed, so an oversized list is refused without being read to the end.

Co-Authored-By: Claude <noreply@anthropic.com>
It needs a live session (the commit before last), so it sits with `GET /v1/me`.
Shorter repeated path prefixes keep docs/api.md inside its 10 KB budget.

Co-Authored-By: Claude <noreply@anthropic.com>
The board's top 25 comes with the map, so a player further down had to page
with "Show more" to find themselves. The board now asks for their entry
(the leaderboard's existing `player=`) and pins it under the top, set apart,
until "Show more" reaches it. Only on the 2.0 board, which is the one that
ranks them, and only when they aren't already in the top.

TableRow gets `separated` for a row that starts a group apart.
Links to SourceJump get shared on Discord all the time, but pages set only a
title, so a preview said nothing about the record. Map, run and player pages
now set a description and Open Graph and Twitter card tags: a map's tier,
the world record of the board it opens on and its players; a run's time,
style, track and place; a player's finished maps and world records. Map and
run previews show the map's cover, player previews the avatar. They reuse
the pages' own per-request reads, so a preview costs no extra API request.

An unexpected failure while rendering a page now shows a "Something went
wrong" page with "Try again", inside the site's header and footer, instead
of Next.js's bare error screen.
The six PRs were cherry-picked onto a newer base, so their generated files
were taken from either side; this brings them back in line with the code. Made
from an empty, migrated database, as the checks use.

Co-Authored-By: Claude <noreply@anthropic.com>
Geist replaces Play (450 regular, 700 bold), with Exo 2 bold for server
names only (the font-server token). Shared pieces for the redesign: a Dot
separator hidden on phones, an xs breakpoint (360px), neutral row hovers,
tap highlight off. Table gains phoneLead/phoneFill so a phone's first view
ends at the ranked column and the rest scrolls; Pager reserves its widest
row so turning a page never moves it. The masthead's phone picture is a
band with a clean edge; Sign in stays off the header's edge.
A record that beat nothing showed its time with no bracket. RecentRun's
gap is null only for a board's first run; a run's page and dialog read the
same from the record history, and stay blank when the history can't place
the run.
A display order in the web only: the ruleset and the Ruleset page keep the
ruleset's order. Making it the ruleset's own order is the lead's call.
Map boards hide the sort arrow until someone sorts, drop avatars on phones
and put the gap under the time. The Maps tier column highlights the chosen
tier in its color. Leaderboards fit the ranked number to a phone's first
view, swapping points and completed on the Completed board. Server names
are one bold face throughout. Ruleset code wraps; spacing fixes elsewhere.
The rank sits large in the header (one line under the name on phones) and
follows the Style and Track menus; it's marked draft while the formula is.
The picture is captioned as the latest world record or personal best,
asked of the API. The strip below keeps completed maps and world records,
compact. Personal bests open by place in the 2.0 view, loading every page
until the API can sort; pre-2.0 views keep map order. WR rows are no
longer highlighted, and the Any-style count is of rows, not maps.
Latest world records lead with the player, then the map, tier and style,
then the time; on phones the map goes under the player. Records and Top
players end level. The header's buttons get their own layer: with the
depth canvas redrawing beneath, GPU Chromium dropped Find a server's hover
color after a frame.
PR sourcejump#16 and the migration numbering, akanora's PRs and the plugin's new key
requirement, the API options that would end the web's shortcuts, and the
style-order question.
…ejump

Map personal bests for servers in one request (now keyed), sign out
everywhere (401 without a session), your own place pinned under a map
board, one view for the tier in force (migration 0054, after PR sourcejump#16's
0052 and 0053), link previews and an error page, and the Windows build.
The map board's rows keep this branch's phone layout inside sourcejump#25's
EntryRow; design-system.md keeps both sides within its budget.
@github-actions
github-actions Bot merged commit e0d75b1 into sourcejump:u/zasbu Nov 8, 2026
3 checks passed
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

Merged into u/zasbu. It'll be live at https://zasbu-sj.okwhiteli.st in a few minutes.

@zasbu
zasbu deleted the feat/mobile-profile-polish branch November 9, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants