reimplement: SHC_3BB0A8C1_0x0047A130 100%#95
Draft
TheRedDaemon wants to merge 1 commit into
Draft
Conversation
Contributor
|
The class definition struct resolver should be removed. |
Contributor
|
I resolved the AttackInfo.hpp thing now in a1971f3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires changes to
AttackInfo: Two new field sizes set.This one showed the shortcomings of the struct resolver:
Unlike the function resolver, which seems to be pretty good at behaving like a normal function, the struct resolver deeply effects the way the compiler handles field accesses. It required activating almost all of them to see the opcodes being produced like in the original. There is a clear difference between having the global or just a reference, no matter how stable. We always have to keep this in mind while testing around.
Also:
privatefunctions should be made public. Pragmatic reason: We can not judge visibility and we can not instantiate classes with constructor if they are private.