reimplement: SHC_3BB0A8C1_0x00471830 and support functions 100%#87
reimplement: SHC_3BB0A8C1_0x00471830 and support functions 100%#87TheRedDaemon wants to merge 2 commits into
Conversation
|
Added logic comments, however, still needs change in class definition of |
gynt
left a comment
There was a problem hiding this comment.
Can you change the name of file copyData+.hpp to something without the +?
Or split them up again in separate files or does that ruin the match?
I would like to stick to the philosophy of the flie location being locatable just by function name and namespace.
|
I can simplify it again to This may happen to us in other cases, too. At least in any moment Ghidra has issues to reuse the ECX, we have to assume they shared a file, and we have to put them together for the perfect match. |
|
I synced the change in .hpp in a1971f3 |
The weird patterns in the copy functions made me use assembly in the end.
Maybe that is the origin, maybe it is not. I found no other way to recreate this pattern.
Is heavily commented.
Also, draft: There needs to be a type change in
LowLevelMemory.hpp.Closes #91 .