Open
Conversation
keegancsmith
approved these changes
May 8, 2026
Member
keegancsmith
left a comment
keegancsmith
left a comment
There was a problem hiding this comment.
big PR that looks super mechanical. So trusting ya tested everything still works :D
Very minor but I ran ./dev/smoke.sh and it worked which is good :)
The command migration is moving legacy commander commands onto urfave/cli so they share the same help, flag, and dispatch behavior as newly migrated commands. Migrate src users and its list, get, create, delete, prune, and tag subcommands to cli.Command definitions. Register both users and user in the migrated command map, and remove users from the legacy docs path so generated docs come from the migrated root command. Test Plan: - go test ./cmd/src - go test ./... - go run ./cmd/src users -h - go run ./cmd/src user -h - go run ./cmd/src users list -h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command migration is moving legacy commander commands onto urfave/cli so they share the same help, flag, and dispatch behavior as newly migrated commands.
Migrate
src usersand itslist,get,create,delete,prune, andtagsubcommands tocli.Commanddefinitions. Register bothusersanduserin the migrated command map, and removeusersfrom the legacy docs path so generated docs come from the migrated root command.Test Plan
go test ./cmd/srcgo test ./...go run ./cmd/src users -hgo run ./cmd/src user -hgo run ./cmd/src users list -h