-
Notifications
You must be signed in to change notification settings - Fork 379
fix(web): match .gitattributes patterns in subdirectories #1692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
breken-ai
wants to merge
5
commits into
sourcebot-dev:main
Choose a base branch
from
breken-ai:fix/gitattributes-nested-patterns
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5cb2d5d
fix(web): match .gitattributes patterns in subdirectories
breken-ai 0dfba19
docs: add changelog entry for #1692
breken-ai 5e9fcf2
fix(web): clear linguist language overrides
breken-ai 321a14c
fix(web): normalize relative gitattributes paths
breken-ai d67fcc7
fix(web): normalize interior dot path segments
breken-ai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import { describe, expect, test } from 'vitest'; | ||
| import { parseGitAttributes, resolveLanguageFromGitAttributes } from './gitattributes'; | ||
|
|
||
| describe('resolveLanguageFromGitAttributes', () => { | ||
| test('a pattern without a slash matches files in any directory', () => { | ||
| const attrs = parseGitAttributes('*.h linguist-language=C\n'); | ||
|
|
||
| expect(resolveLanguageFromGitAttributes('foo.h', attrs)).toBe('C'); | ||
| expect(resolveLanguageFromGitAttributes('src/include/foo.h', attrs)).toBe('C'); | ||
| }); | ||
|
|
||
| test('a pattern with a leading slash is anchored to the repository root', () => { | ||
| const attrs = parseGitAttributes('/config.in linguist-language=Makefile\n'); | ||
|
|
||
| expect(resolveLanguageFromGitAttributes('config.in', attrs)).toBe('Makefile'); | ||
| expect(resolveLanguageFromGitAttributes('sub/config.in', attrs)).toBeUndefined(); | ||
| }); | ||
|
|
||
| test('a pattern with an inner slash is matched relative to the repository root', () => { | ||
| const attrs = parseGitAttributes('docs/*.txt linguist-language=Markdown\n'); | ||
|
|
||
| expect(resolveLanguageFromGitAttributes('docs/intro.txt', attrs)).toBe('Markdown'); | ||
| expect(resolveLanguageFromGitAttributes('./docs/intro.txt', attrs)).toBe('Markdown'); | ||
| expect(resolveLanguageFromGitAttributes('./docs/./intro.txt', attrs)).toBe('Markdown'); | ||
| expect(resolveLanguageFromGitAttributes('other/docs/intro.txt', attrs)).toBeUndefined(); | ||
| }); | ||
|
|
||
| test('the last matching rule wins', () => { | ||
| const attrs = parseGitAttributes('*.inc linguist-language=PHP\nlegacy/*.inc linguist-language=Pascal\n'); | ||
|
|
||
| expect(resolveLanguageFromGitAttributes('src/a.inc', attrs)).toBe('PHP'); | ||
| expect(resolveLanguageFromGitAttributes('legacy/a.inc', attrs)).toBe('Pascal'); | ||
| }); | ||
|
|
||
| test('dotfiles match slashless patterns', () => { | ||
| const attrs = parseGitAttributes('*.conf linguist-language=TOML\n'); | ||
|
|
||
| expect(resolveLanguageFromGitAttributes('src/.config.conf', attrs)).toBe('TOML'); | ||
| }); | ||
|
|
||
| test.each(['-linguist-language', '!linguist-language'])('%s clears the previous language override', (reset) => { | ||
| const attrs = parseGitAttributes(`*.inc linguist-language=PHP\nlegacy/*.inc ${reset}\n`); | ||
|
|
||
| expect(resolveLanguageFromGitAttributes('legacy/a.inc', attrs)).toBeUndefined(); | ||
| }); | ||
|
|
||
| test('a later language value replaces a reset', () => { | ||
| const attrs = parseGitAttributes( | ||
| '*.inc linguist-language=PHP\nlegacy/*.inc -linguist-language\nlegacy/special.inc linguist-language=Pascal\n', | ||
| ); | ||
|
|
||
| expect(resolveLanguageFromGitAttributes('legacy/special.inc', attrs)).toBe('Pascal'); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.