fix(gcs): pass bucket_name to multistore GCS store#193
Merged
alukach merged 1 commit intoJul 22, 2026
Conversation
The GCS arm of build_backend_options resolved backend_type=gcs but never inserted the `bucket_name` option, so multistore failed with "config error: failed to build GCS paginated store: Missing bucket name" (500 InternalError) on every request to a GCS-backed product. Mirror the s3 arm: insert `bucket_name` from connection.details.bucket. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
alukach
marked this pull request as ready for review
July 22, 2026 22:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GCS-backed products 500 on every request in staging:
The provider now resolves correctly (
backend_type=gcs), butbuild_backend_optionsreturned thegcsbackend type with an empty options map — it never setbucket_name, which multistore's GCS store requires (bucket_name,service_account_key,skip_signature— see multistoretypes.rs). Thes3arm already insertsbucket_namefromconnection.details.bucket; thegcsarm was missing the equivalent line.Fix
Mirror the
s3arm: insertbucket_namefromdetails.bucketin thegcsarm.Testing
cargo test(all native suites) + wasm build/clippy green via pre-commit hook.🤖 Generated with Claude Code