Initial Conductor Migration (Repeat Module Migration, Testing, Documentation)#698
Initial Conductor Migration (Repeat Module Migration, Testing, Documentation)#698AaravMalani wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the repeat bundle to use Conductor types and introduces a new testplugin package with an in-memory TestDataHandler for testing. It also adds documentation normalization tools to map Conductor implementation details to the public API surface. Feedback on these changes includes lifting recursive closure creation out of the generator in repeat to improve performance, adding optional chaining to prevent a potential TypeError in the documentation builder, cloning initial array values in TestDataHandler to avoid shared-state mutations, and implementing cycle detection in list_to_vec to prevent infinite loops.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Just for some general queries: was it difficult to figure out how the repository worked? Was understanding/modifying the |
|
|
||
| describe(normalizeConductorType, () => { | ||
| it('maps TypedValue numbers to native numbers', () => { | ||
| const project = createProject(); |
There was a problem hiding this comment.
If project needs to be created every single time, would it be better to provide it as a test fixture?
There was a problem hiding this comment.
I think the file can afford to be split up, but otherwise thanks for taking the time to write the docstrings
Description
This PR kickstarts the initial migration of the modules to the Conductor framework. It
@sourceacademy/modules-testplugin) for Conductor testing utilities (including a sample native evaluator)Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
yarn build:libs && yarn build:docsand verifying that the documentation has been unaffectedsrc/bundles/repeatlib/testpluginlib/buildtools/src/build/docs/conductor.tsChecklist: