Skip to content

Add new cross-match catalogs - #53

Draft
jeanconn wants to merge 19 commits into
stack/05-db-write-hardeningfrom
stack/06-crossmatch-catalogs
Draft

Add new cross-match catalogs#53
jeanconn wants to merge 19 commits into
stack/05-db-write-hardeningfrom
stack/06-crossmatch-catalogs

Conversation

@jeanconn

Copy link
Copy Markdown
Contributor

Description

  • add the new external catalog integrations and the supporting cross-match logic
    for ICRF3, RFC, GaiaAGN, GaiaQSO, GaiaVarStar, MilliquasGaia, and
    DESIV161
  • add the astromon_23 through astromon_27 match sets that use those catalogs (though we may not keep any of these)
  • route catalog caches and archive data under ASTROMON_DATA_DIR
  • keep test data out of the production cache location
  • update the catalog-data scripts and docs to match the new sources and cache layout
  • remove local smoke tests that depended on preexisting cache state

Interface Impacts

  • cache and archive locations move under ASTROMON_DATA_DIR

Testing

  • adds and expands unit tests for the new catalog getters, DESI deduplication,
    cache behavior, match-set definitions, and the catalog data pipeline wiring

Migration

  • after the full stack is approved and merged, either move existing caches under
    ASTROMON_DATA_DIR or rebuild them there

Unit tests

  • No unit tests
  • Mac
  • Linux
  • Windows

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant