Add solver and interrupted exceptions to all prover methods#676
Draft
baierd wants to merge 27 commits into
Draft
Add solver and interrupted exceptions to all prover methods#676baierd wants to merge 27 commits into
baierd wants to merge 27 commits into
Conversation
…er with new abstract methods that implement their behavior, so that the common checks are in a central class and guaranteed to be called in all cases + remove the now redundant checks from the implementations
…erforms common checks before delegating to a new implementation method getUnsatCoreImpl() (that is implemented by all solvers that can generate unsat cores)
…rover that performs common checks before delegating to a new implementation method unsatCoreOverAssumptionsImpl() (that is implemented by all solvers) a default impl for unsatCoreOverAssumptionsImpl() is not possible due to javac complaining wrongly in the CI
…ould not be public
…ould not be public
…llSatImpl after all common checks. AllSatImpl now handles all AllSat implementations and redundant checks are removed
…hecks and a delegate method that can be implemented by the solvers
…, check for interrupts in all solver touching API and throw InterruptedException in all methods that may be interrupted (including changes to getStatistics(), as it also uses solver functions)
…ver shutdown + add common API shutdownIfNecessary() in AbstractProver that handles this
… have it in AbstractProver
…utdownManager should shut down without needing to use the manager
… AbstractProver instead of using the notifier directly
…del_generation_api_through_impl_delegates
…o add_common_impl_for_unsatCore_allSat
…nd_interruptedExceptions_to_all_prover_methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
ProverExceptions andInterruptedExceptions to allProver*,Evaluator* andModel* interface methods interacting with solvers in preparation for Prover based interrupts.This PR is based on #674 and should only be merged after it.