Handle model generation api through implementation delegates#673
Merged
baierd merged 10 commits intoJun 12, 2026
Conversation
…er with new abstract methods that implement their behavior, so that the common checks are in a central class and guaranteed to be called in all cases + remove the now redundant checks from the implementations
…del_generation_api_through_impl_delegates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model generating API (e.g. getModel()) was implemented for every solver. Meaning that also all checks that are required before executing solver specific code were added on a per solver basis. Since this is error prone, this PR collects these common checks now in
AbstractProverand delegates the solver specific implementations to new, internal API that does no longer need to think about these common checks.Note: i did not remove the default implementations in
BasicProverEnvironment, as this would potentially break client code that inherits from it.To be merged after #671 as it is based on its branch.