docs: open with the live-server verification, drop a brittle count - #1
Merged
Merged
Conversation
The strongest argument here is that the queries are checked against a real PostgreSQL with an awkward fixture rather than mocked, including real sessions made to block each other. That was at line 141 of 247. The transcript also asserted 'slowQueries 2 rows'. A real run gives 0 -- the count depends on what pg_stat_statements has observed. Corrected, and noted that the PASS lines are the assertions while the counts beside them are not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the real-database verification to the first screen — it is the repo's best argument and sat at line 141 of 247.
Also: the transcript claimed
slowQueries 2 rows; an actual run against the fixture gives0, because the count depends on whatpg_stat_statementshas seen. Corrected and annotated so the incidental numbers are not read as assertions. Verified by runningdocker compose -f docker-compose.test.yml up -d && node server/scripts/verify-queries.js— 10 queries, 0 checks failed.Gate passes.