[restapi] Disable TLS session tickets to fix FIPS AES-128-CTR panic#187
Open
ganglyu wants to merge 1 commit into
Open
[restapi] Disable TLS session tickets to fix FIPS AES-128-CTR panic#187ganglyu wants to merge 1 commit into
ganglyu wants to merge 1 commit into
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Go's TLS 1.3 server uses AES-128-CTR to encrypt NewSessionTicket payloads, which the SymCrypt FIPS provider does not implement, causing the golang-fips/openssl binding to panic on the first HTTPS request. Disable session tickets to fall back to full handshakes. Signed-off-by: Geoffrey Lyu <glv@nvidia.com>
2a4f7d7 to
4bc717a
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
approved these changes
May 27, 2026
keboliu
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
When
restapiis built with the FIPS-patched Go toolchain (Trixie / Go 1.24+fips) and the SymCrypt OpenSSL provider is the active FIPS provider, the first HTTPS request panics during the TLS 1.3 handshake:Go's TLS 1.3 server uses AES-128-CTR to encrypt
NewSessionTicketpayloads.golang-fips/openssl/v2routes the cipher allocation to OpenSSL'sEVP_CIPHER_fetch, and the SymCrypt FIPS provider does not implementAES-128-CTR, so the fetch returnsNULLand the binding panics.How I did it
Set
SessionTicketsDisabled: trueon the HTTPS server'stls.Config. Session resumption via tickets is not a load-bearing feature for the management REST API, and TLS handshakes still complete normally — they just go through a full handshake every time rather than resuming.How to verify it
On a SONiC image built with
INCLUDE_FIPS=y+ Trixie restapi container::8081.tail /var/log/syslogshowshttp: panic serving ... crypto/cipher: unsupported cipher: AES-128and the connection is reset.SSL handshake has read X bytes and written Y bytes,Protocol: TLSv1.3,Cipher is TLS_AES_128_GCM_SHA256); syslog has no panic.