[sonic_xcvr] Use advertised timeouts for CDB firmware commands#681
Open
pnakka28 wants to merge 1 commit into
Open
[sonic_xcvr] Use advertised timeouts for CDB firmware commands#681pnakka28 wants to merge 1 commit into
pnakka28 wants to merge 1 commit into
Conversation
Signed-off-by: Pavan Kalyan Nakka <pnakka@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use module advertised timeouts for CDB firmware commands. This change parses the
MaxDurationfields and uses them as per-command timeouts for firmware operations. These timeouts are passed to the Start, Abort, Write, and Complete firmware commands. Commands without a spec definedMaxDurationcontinue to use the default timeout. Unit tests have been updated accordingly.Motivation and Context
The CDB firmware commands previously used a default timeout for all operations. However, per CMIS spec, modules advertise per command MaxDuration values, and commands can have different execution times. This change ensures to respect module advertised timing constraints as defined in the CMIS specification.
How Has This Been Tested?
MaxDurationvalues are correctly parsed from the moduletest_cdb_fw.pyandtest_cdb.pypass with new timeout parametersAdditional Information (Optional)
MSFT ADO - 38035182