Add CPO module identifier (0x80) to SFF-8024 XCVR identifier tables#676
Open
tshalvi wants to merge 1 commit into
Open
Add CPO module identifier (0x80) to SFF-8024 XCVR identifier tables#676tshalvi wants to merge 1 commit into
tshalvi wants to merge 1 commit into
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: tshalvi <tshalvi@nvidia.com>
tshalvi
force-pushed
the
master_add_cpo_xcvr_identifier
branch
from
9ea42de to
55b035b
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Junchao-Mellanox
approved these changes
May 26, 2026
Contributor
aditya-nexthop
left a comment
aditya-nexthop
left a comment
There was a problem hiding this comment.
Based on the discussion today, CPO will have its own factories with platform specified CPO IDs. Would that approach make this change unnecessary?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the SFF-8024 Identifier value
0x80(decimal128) for Co-Packaged Optics (CPO) modules to theSff8024code class insonic_platform_base/sonic_xcvr/codes/public/sff8024.py:XCVR_IDENTIFIERS[128] = 'CPO'XCVR_IDENTIFIER_ABBRV[128] = 'CPO'Motivation and Context
CPO is a new module form factor whose SFF-8024 Identifier (
0x80) was not present in SONiC'sXCVR_IDENTIFIERS/XCVR_IDENTIFIER_ABBRVtables. As a result, CPO modules were decoded as "Unknown", andtype/type_abbrv_nameinTRANSCEIVER_INFOwere left empty, which prevented the rest of the stack from recognising them as a known form factor.Adding this mapping lets SONiC correctly identify CPO modules end-to-end, and is the prerequisite that allows them to be picked up by the CMIS state machine in
xcvrdHow Has This Been Tested?
Manual testing.
Additional Information (Optional)