fix: harden protocol and transport handling - #8
Merged
Conversation
abcsnowwolf
commented
Jul 28, 2026
abcsnowwolf
commented
Contributor
- require explicit HttpMCPServer::begin() so tool registration cannot race in-flight requests; construction no longer starts the listener (breaking change over released 0.3.0)
- validate the JSON-RPC envelope (jsonrpc version, id type, params shape) and require mandatory initialize/tools params per the MCP spec
- enforce an aggregate byte budget on the BLE RX queue (-DMCP_BLE_RX_QUEUE_MAX_BYTES, default 16 KB) and migrate McpBle/BLEMCPServer shared state to std::atomic
- drop the redundant NimBLE service start (2.x starts services when advertising begins)
- reject non-JSON Content-Type on POSTs that carry a body; omit empty schema type from tools/list output
- fix the transport send retry loop that never terminated when max_retries == 255
- bump version to 0.4.0 and point examples at ESP-MCP ^0.4.0
* require explicit HttpMCPServer::begin() so tool registration cannot race in-flight requests; construction no longer starts the listener (breaking change over released 0.3.0) * validate the JSON-RPC envelope (jsonrpc version, id type, params shape) and require mandatory initialize/tools params per the MCP spec * enforce an aggregate byte budget on the BLE RX queue (-DMCP_BLE_RX_QUEUE_MAX_BYTES, default 16 KB) and migrate McpBle/BLEMCPServer shared state to std::atomic * drop the redundant NimBLE service start (2.x starts services when advertising begins) * reject non-JSON Content-Type on POSTs that carry a body; omit empty schema type from tools/list output * fix the transport send retry loop that never terminated when max_retries == 255 * bump version to 0.4.0 and point examples at ESP-MCP ^0.4.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.