Use bare config accessors - #336
Merged
Merged
Conversation
Replace Spree::Config[:foo] with the bare accessors. Both dispatch to the same preferred_foo body; the bare form skips has_preference!'s array scan and matches the form used by Solidus core and most of this codebase. A store that overrides preferred_foo on a configuration class no longer affects these reads. Nothing in this workspace does that.
jarednorman
force-pushed
the
align-config-accessors
branch
from
September 3, 2026 16:57
059880b to
496d2a5
Compare
adammathys
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is mostly just a consistency thing, but the bare accessors are also ever-so-slightly more performant.
Checklist