Skip to content

Ci upload failure artifacts - #338

Merged
adammathys merged 1 commit into
solidusio:mainfrom
SuperGoodSoft:ci-upload-failure-artifacts
Sep 15, 2026
Merged

adammathys merged 1 commit into
solidusio:mainfrom
SuperGoodSoft:ci-upload-failure-artifacts

Conversation

@AlistairNorman

Copy link
Copy Markdown
Contributor

Summary

Artifacts haven't been uploading which makes debugging hard. This fixes that.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@AlistairNorman
AlistairNorman force-pushed the ci-upload-failure-artifacts branch 2 times, most recently from 0ae46b1 to d63db14 Compare September 3, 2026 15:45
test-solidus-extension uploads from spec/dummy/tmp and hardcodes one artifact
name, so nothing was ever captured. Upload from dummy-app/tmp/capybara named
per matrix job, with the test log alongside.
@AlistairNorman
AlistairNorman force-pushed the ci-upload-failure-artifacts branch from d63db14 to c9a7f68 Compare September 3, 2026 15:50
@AlistairNorman AlistairNorman self-assigned this Sep 3, 2026
@AlistairNorman
AlistairNorman marked this pull request as ready for review September 3, 2026 15:53
@adammathys
adammathys merged commit cdf1784 into solidusio:main Sep 15, 2026
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants